Fix the copyright header on the policy protobufs.

Fix the copyright header on the policy protobufs.

These files were moved and the header was automatically updated to remove the
"(c)". However, this will make the presubmit scripts fail if a proto is updated.

BUG=271392
R=mnissler@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240259

[Joao da Silva, 2013-12-11 15:05:24]

Something is "fixing" copyright headers before a commit makes it to SVN, but
this will break the presubmit scripts if the protos are updated. Note that the
protos moved in https://codereview.chromium.org/108563005/ had the original
headers in the CL.

I'm not sure if fixing the "(c)" will prevent this rewrite from happening again.
I don't think changing the previous copyright year to 2013 is the right thing to
do.

WDYT?

[Mattias Nissler (ping if slow), 2013-12-11 15:53:29]

I think the automatic fixing was intentional - can't we just update the
other copy to also say 2013?

-----------------------------------------------
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Steuernummer: 48/725/00206
Umsatzsteueridentifikationsnummer: DE813741370


On Wed, Dec 11, 2013 at 4:05 PM, <joaodasilva@chromium.org> wrote:

> Reviewers: Mattias Nissler,
>
> Message:
> Something is "fixing" copyright headers before a commit makes it to SVN,
> but
> this will break the presubmit scripts if the protos are updated. Note that
> the
> protos moved in https://codereview.chromium.org/108563005/ had the
> original
> headers in the CL.
>
> I'm not sure if fixing the "(c)" will prevent this rewrite from happening
> again.
> I don't think changing the previous copyright year to 2013 is the right
> thing to
> do.
>
> WDYT?
>
> Description:
> Fix the copyright header on the policy protobufs.
>
> These files were moved and the header was automatically updated to remove
> the
> "(c)". However, this will make the presubmit scripts fail if a proto is
> updated.
>
> BUG=271392
>
> Please review this at https://codereview.chromium.org/112893002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+9, -9 lines):
>   M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
>   M chrome/browser/chromeos/policy/proto/install_attributes.proto
>   M chrome/browser/policy/proto/chromeos/chrome_device_policy.proto
>   M chrome/browser/policy/proto/chromeos/install_attributes.proto
>   M chrome/browser/policy/proto/cloud/chrome_extension_policy.proto
>   M chrome/browser/policy/proto/cloud/device_management_backend.proto
>   M chrome/browser/policy/proto/cloud/device_management_local.proto
>   M components/policy/proto/device_management_backend.proto
>   M components/policy/proto/device_management_local.proto
>
>
> Index: chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
> diff --git a/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
> b/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
> index 975beb5bc84c8abf97da57f600454a55eba4cd1e..
> cd562e2054ea8b62c23f9bf4d5d9744e657b344a 100644
> --- a/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
> +++ b/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
> @@ -1,4 +1,4 @@
> -// Copyright 2013 The Chromium Authors. All rights reserved.
> +// Copyright 2012 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: chrome/browser/chromeos/policy/proto/install_attributes.proto
> diff --git a/chrome/browser/chromeos/policy/proto/install_attributes.proto
> b/chrome/browser/chromeos/policy/proto/install_attributes.proto
> index 396794ba4216680cfca56be3233000641d035e6e..
> 9649610b16983347d0fea8c303bc56cfe4139f91 100644
> --- a/chrome/browser/chromeos/policy/proto/install_attributes.proto
> +++ b/chrome/browser/chromeos/policy/proto/install_attributes.proto
> @@ -1,4 +1,4 @@
> -// Copyright 2013 The Chromium Authors. All rights reserved.
> +// Copyright 2011 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: chrome/browser/policy/proto/chromeos/chrome_device_policy.proto
> diff --git a/chrome/browser/policy/proto/chromeos/chrome_device_policy.proto
> b/chrome/browser/policy/proto/chromeos/chrome_device_policy.proto
> index b841f1ff576108f41412b7acd5c0c594cbdbe799..
> cd562e2054ea8b62c23f9bf4d5d9744e657b344a 100644
> --- a/chrome/browser/policy/proto/chromeos/chrome_device_policy.proto
> +++ b/chrome/browser/policy/proto/chromeos/chrome_device_policy.proto
> @@ -1,4 +1,4 @@
> -// Copyright (c) 2012 The Chromium Authors. All rights reserved.
> +// Copyright 2012 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: chrome/browser/policy/proto/chromeos/install_attributes.proto
> diff --git a/chrome/browser/policy/proto/chromeos/install_attributes.proto
> b/chrome/browser/policy/proto/chromeos/install_attributes.proto
> index f1442f4ff35a1ab53861a6fc5bafe0f8970a740c..
> 9649610b16983347d0fea8c303bc56cfe4139f91 100644
> --- a/chrome/browser/policy/proto/chromeos/install_attributes.proto
> +++ b/chrome/browser/policy/proto/chromeos/install_attributes.proto
> @@ -1,4 +1,4 @@
> -// Copyright (c) 2011 The Chromium Authors. All rights reserved.
> +// Copyright 2011 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: chrome/browser/policy/proto/cloud/chrome_extension_policy.proto
> diff --git a/chrome/browser/policy/proto/cloud/chrome_extension_policy.proto
> b/chrome/browser/policy/proto/cloud/chrome_extension_policy.proto
> index 27da746b5a2886456233900db552f25f70e0d2cc..
> d48281043cd0c5dc2eb3992395acfa8511e1cf46 100644
> --- a/chrome/browser/policy/proto/cloud/chrome_extension_policy.proto
> +++ b/chrome/browser/policy/proto/cloud/chrome_extension_policy.proto
> @@ -1,4 +1,4 @@
> -// Copyright (c) 2013 The Chromium Authors. All rights reserved.
> +// Copyright 2013 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: chrome/browser/policy/proto/cloud/device_management_backend.proto
> diff --git
a/chrome/browser/policy/proto/cloud/device_management_backend.proto
> b/chrome/browser/policy/proto/cloud/device_management_backend.proto
> index dce49a6e851ef0828196f8a20d9915ab8a90a31c..
> 6b1b91f0652570500998d53f048d2048e664995f 100644
> --- a/chrome/browser/policy/proto/cloud/device_management_backend.proto
> +++ b/chrome/browser/policy/proto/cloud/device_management_backend.proto
> @@ -1,4 +1,4 @@
> -// Copyright (c) 2012 The Chromium Authors. All rights reserved.
> +// Copyright 2012 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: chrome/browser/policy/proto/cloud/device_management_local.proto
> diff --git a/chrome/browser/policy/proto/cloud/device_management_local.proto
> b/chrome/browser/policy/proto/cloud/device_management_local.proto
> index 122e86360c8683986a6c3dded8690c7f764508e6..
> 9b41882469ee6e980cdbc1fe82bbfd2fc0e3daea 100644
> --- a/chrome/browser/policy/proto/cloud/device_management_local.proto
> +++ b/chrome/browser/policy/proto/cloud/device_management_local.proto
> @@ -1,4 +1,4 @@
> -// Copyright (c) 2011 The Chromium Authors. All rights reserved.
> +// Copyright 2011 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: components/policy/proto/device_management_backend.proto
> diff --git a/components/policy/proto/device_management_backend.proto
> b/components/policy/proto/device_management_backend.proto
> index 5ae703af54c1ff7fe473dac9dba92b12548e2cce..
> 6b1b91f0652570500998d53f048d2048e664995f 100644
> --- a/components/policy/proto/device_management_backend.proto
> +++ b/components/policy/proto/device_management_backend.proto
> @@ -1,4 +1,4 @@
> -// Copyright 2013 The Chromium Authors. All rights reserved.
> +// Copyright 2012 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> Index: components/policy/proto/device_management_local.proto
> diff --git a/components/policy/proto/device_management_local.proto
> b/components/policy/proto/device_management_local.proto
> index 271c7bf3d90cde04743bfad916000af89dcd65f3..
> 9b41882469ee6e980cdbc1fe82bbfd2fc0e3daea 100644
> --- a/components/policy/proto/device_management_local.proto
> +++ b/components/policy/proto/device_management_local.proto
> @@ -1,4 +1,4 @@
> -// Copyright 2013 The Chromium Authors. All rights reserved.
> +// Copyright 2011 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Joao da Silva, 2013-12-11 17:47:22]

On 2013/12/11 15:53:29, Mattias Nissler wrote:
> I think the automatic fixing was intentional - can't we just update the
> other copy to also say 2013?
> 

I'm not sure what you mean by that.

This script seems to be removing the "(c)" in new files. So what this change
does it:
- remove the "(c)" from the original files at chrome/browser/policy/proto,
without changing the copyright year;
- update the files at the new locations to match that, by setting the copyright
year to the original value.

Are you suggesting that we just set the copyright year to 2013 on all files?

[Mattias Nissler (ping if slow), 2013-12-11 17:52:02]

On 2013/12/11 17:47:22, Joao da Silva wrote:
> On 2013/12/11 15:53:29, Mattias Nissler wrote:
> > I think the automatic fixing was intentional - can't we just update the
> > other copy to also say 2013?
> > 
> 
> I'm not sure what you mean by that.
> 
> This script seems to be removing the "(c)" in new files. So what this change
> does it:
> - remove the "(c)" from the original files at chrome/browser/policy/proto,
> without changing the copyright year;
> - update the files at the new locations to match that, by setting the
copyright
> year to the original value.
> 
> Are you suggesting that we just set the copyright year to 2013 on all files?

Yes. I think there was an email thread on chromium-dev regarding copyright
headers a while back which may have more information.

[Joao da Silva, 2013-12-11 19:59:36]

Thanks for the comments (also offline). Instead of mucking with the copyright
year let's just have the presubmit scripts skip that part.

Ready for another look!

[Mattias Nissler (ping if slow), 2013-12-11 20:08:07]

LGTM

[commit-bot: I haz the power, 2013-12-11 20:11:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/112893002/20001

[commit-bot: I haz the power, 2013-12-11 22:04:15]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-12-11 22:24:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/112893002/40001

[Joao da Silva, 2013-12-12 07:44:00]

Committed patchset #3 manually as r240259 (presubmit successful).