Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 108563005: Move the cloud policy protobufs into the component. (Closed)

Created:
7 years ago by Joao da Silva
Modified:
7 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, dkrahn+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move the cloud policy protobufs into the component. This change moved chrome/browser/policy/proto/chromeos to chrome/browser/chromeos/policy/proto, and chrome/browser/policy/proto/cloud to components/policy/proto. This enables the component code to use the cloud policy protobufs, so that iOS can use cloud policy. The old location is still kept temporarily until new git mirrors are set up pointing to the new locations. A couple of PRESUBMIT scripts check that the files are kept in sync. BUG=271392, 327345 TBR=mnissler@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240108

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -114 lines) Patch
M chrome/browser/chromeos/attestation/attestation_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_screen_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_validator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/policy/proto/PRESUBMIT.py View 1 chunk +67 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/policy/proto/install_attributes.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_disk_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_token_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_oauth2_token_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_cache.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_cache_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui_proxy_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/test_request_interceptor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_store.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_android.cc View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/policy/proto/PRESUBMIT.py View 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 4 chunks +2 lines, -5 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M components/policy.gypi View 1 1 chunk +18 lines, -9 lines 0 comments Download
M components/policy/core/DEPS View 1 1 chunk +5 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client_registration_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_store.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/device_management_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/mock_cloud_policy_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/mock_device_management_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/policy_builder.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/policy_builder.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
A components/policy/proto/PRESUBMIT.py View 1 chunk +67 lines, -0 lines 0 comments Download
A + components/policy/proto/chrome_extension_policy.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/policy/proto/device_management_backend.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/policy/proto/device_management_local.proto View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
PTAL. The gyp changes are important, the rest is mostly mechanical.
7 years ago (2013-12-10 16:27:58 UTC) #1
Mattias Nissler (ping if slow)
LGTM Note that you could have saved me quite some time had you uploaded a ...
7 years ago (2013-12-11 10:39:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/108563005/40001
7 years ago (2013-12-11 12:43:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=40608
7 years ago (2013-12-11 13:15:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/108563005/40001
7 years ago (2013-12-11 13:21:58 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-11 14:50:27 UTC) #6
Message was sent while issue was closed. 
Change committed as 240108

Powered by Google App Engine
This is Rietveld 408576698