Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128913003: Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg (Closed)

Created:
5 years, 7 months ago by sergeyv
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg TBR=vitalybuka BUG=177163 Committed: https://crrev.com/81834cca312ad12091b40ebdab5ec9ca6db1c418 Cr-Commit-Position: refs/heads/master@{#329615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128913003/1
5 years, 7 months ago (2015-05-13 10:23:43 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 11:22:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128913003/1
5 years, 7 months ago (2015-05-13 11:23:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 11:27:19 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/81834cca312ad12091b40ebdab5ec9ca6db1c418 Cr-Commit-Position: refs/heads/master@{#329615}
5 years, 7 months ago (2015-05-13 11:28:01 UTC) #9
sergeyv
5 years, 7 months ago (2015-05-13 12:54:28 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1125413007/ by sergeyv@chromium.org.

The reason for reverting is: Doesnt fix GcdPrivateAPITest.WifiPasswords on win
dbg:

http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%....

Powered by Google App Engine
This is Rietveld 408576698