Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4207)

Unified Diff: chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc

Issue 1128913003: Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
diff --git a/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc b/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
index 434ab8e08d9ff21ea95bbc6408101ff7dbde63ef..ad19c4f1cb200686a35e3e46aec5ba34508c7b06 100644
--- a/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
+++ b/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
@@ -361,13 +361,8 @@ IN_PROC_BROWSER_TEST_F(GcdPrivateAPITest, WifiMessage) {
}
IN_PROC_BROWSER_TEST_F(GcdPrivateAPITest, WifiPasswords) {
-// TODO(noamsml): Win Dbg has a workaround that makes RunExtensionSubtest
-// always return true without actually running the test. Remove when fixed.
-// See http://crbug.com/177163 for details.
-#if !defined(OS_WIN) || defined(NDEBUG)
EXPECT_CALL(wifi_manager_factory_, WifiManagerCreated())
.WillOnce(Invoke(this, &GcdPrivateAPITest::OnCreateWifiManager));
-#endif
EXPECT_TRUE(RunExtensionSubtest("gcd_private/api", "wifi_password.html"));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698