Add minimal profile creation version for default apps install on Chrome OS

Add minimal profile creation version for default apps install on Chrome OS

BUG=483627
TEST=unit_tests

Committed: https://crrev.com/2c6ef293713752f2e6bfca9401f54bc30adcdcf4
Cr-Commit-Position: refs/heads/master@{#329412}

[Dmitry Polukhin, 2015-05-06 15:27:16]

dpolukhin@chromium.org changed reviewers:
+ asargent@chromium.org

[Dmitry Polukhin, 2015-05-06 15:27:17]

PTAL

[Dmitry Polukhin, 2015-05-07 10:46:10]

The CQ bit was checked by dpolukhin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 10:46:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128753003/20001

[commit-bot: I haz the power, 2015-05-07 11:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 11:02:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dmitry Polukhin, 2015-05-07 13:24:54]

The CQ bit was checked by dpolukhin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 13:25:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128753003/20001

[commit-bot: I haz the power, 2015-05-07 13:58:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 13:58:44]

Dry run: This issue passed the CQ dry run.

[Dmitry Polukhin, 2015-05-08 09:49:11]

Antony, friendly ping, could you please take a look.

[asargent_no_longer_on_chrome, 2015-05-08 20:53:26]

Sorry for delay

https://codereview.chromium.org/1128753003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/1128753003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/external_provider_impl.cc:262: 
This method is getting really long, so it would be nice to start using separate
methods to break it up. 

Also I'm not crazy about having lots of #ifdef'd code blocks. Does this really
need to be ChromeOS specific? If it does, can we have a flag for turning this
behavior on/off and push the logic for whether that flag is passed in one of the
existing ifdef blocks somewhere like
ExternalProviderImpl::CreateExternalProviders?

[Dmitry Polukhin, 2015-05-09 07:36:50]

PATL

https://codereview.chromium.org/1128753003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/1128753003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/external_provider_impl.cc:262: 
On 2015/05/08 20:53:25, Antony Sargent wrote:
> This method is getting really long, so it would be nice to start using
separate
> methods to break it up. 
> 
> Also I'm not crazy about having lots of #ifdef'd code blocks. Does this really
> need to be ChromeOS specific? If it does, can we have a flag for turning this
> behavior on/off and push the logic for whether that flag is passed in one of
the
> existing ifdef blocks somewhere like
> ExternalProviderImpl::CreateExternalProviders?
> 

Done. I just removed #ifdef there is nothing really Chrome OS specific there.

[Dmitry Polukhin, 2015-05-09 07:37:03]

The CQ bit was checked by dpolukhin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-09 07:41:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128753003/40001

[commit-bot: I haz the power, 2015-05-09 12:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 12:14:43]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Dmitry Polukhin, 2015-05-09 14:00:58]

The CQ bit was checked by dpolukhin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-09 14:01:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128753003/40001

[commit-bot: I haz the power, 2015-05-09 22:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 22:37:48]

Dry run: This issue passed the CQ dry run.

[asargent_no_longer_on_chrome, 2015-05-11 19:03:06]

lgtm

https://codereview.chromium.org/1128753003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/1128753003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:5539: #if
defined(OS_CHROMEOS)
Can we remove the OS_CHROMEOS ifdef here too?

[Dmitry Polukhin, 2015-05-12 14:52:19]

Thank you for the review!

https://codereview.chromium.org/1128753003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/1128753003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:5539: #if
defined(OS_CHROMEOS)
On 2015/05/11 19:03:05, Antony Sargent wrote:
> Can we remove the OS_CHROMEOS ifdef here too?

Done. Sorry, I forgot about this ifdef.

[Dmitry Polukhin, 2015-05-12 14:52:34]

The CQ bit was checked by dpolukhin@chromium.org

[Dmitry Polukhin, 2015-05-12 14:52:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1128753003/#ps60001
(title: "removed #ifdef")

[commit-bot: I haz the power, 2015-05-12 14:53:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128753003/60001

[commit-bot: I haz the power, 2015-05-12 16:06:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-12 16:07:09]

Patchset 4 (id:??) landed as
https://crrev.com/2c6ef293713752f2e6bfca9401f54bc30adcdcf4
Cr-Commit-Position: refs/heads/master@{#329412}