Add minimal profile creation version for default apps install on Chrome OS

chrome/browser/extensions/extension_service_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
 #include "base/at_exit.h"
 #include "base/basictypes.h"
@@ skipping 443 matching lines @@
     }
     return true;
   }
 
   void OnExternalProviderReady(
       const extensions::ExternalProviderInterface* provider) override {
     EXPECT_EQ(provider, provider_.get());
     EXPECT_TRUE(provider->IsReady());
   }
 
+  Profile* profile() { return profile_.get(); }
+
  private:
   int ids_found_;
   base::FilePath fake_base_path_;
   int expected_creation_flags_;
   scoped_ptr<extensions::ExternalProviderImpl> provider_;
   scoped_ptr<base::DictionaryValue> prefs_;
   scoped_ptr<TestingProfile> profile_;
 
   DISALLOW_COPY_AND_ASSIGN(MockProviderVisitor);
 };
@@ skipping 5052 matching lines @@
       base_path, Extension::WAS_INSTALLED_BY_OEM);
   json_data =
       "{"
       "  \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\": {"
       "    \"external_crx\": \"RandomExtension.crx\","
       "    \"external_version\": \"1.0\","
       "    \"was_installed_by_oem\": true"
       "  }"
       "}";
   EXPECT_EQ(1, was_installed_by_eom_visitor.Visit(json_data));
+
+#if defined(OS_CHROMEOS)

[asargent_no_longer_on_chrome, 2015/05/11 19:03:05]

Can we remove the OS_CHROMEOS ifdef here too?

[Dmitry Polukhin, 2015/05/12 14:52:18]

Done. Sorry, I forgot about this ifdef.

+  // Test min_profile_created_by_version.
+  MockProviderVisitor min_profile_created_by_version_visitor(base_path);
+  json_data =
+      "{"
+      "  \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\": {"
+      "    \"external_crx\": \"RandomExtension.crx\","
+      "    \"external_version\": \"1.0\","
+      "    \"min_profile_created_by_version\": \"42.0.0.1\""
+      "  },"
+      "  \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\": {"
+      "    \"external_crx\": \"RandomExtension2.crx\","
+      "    \"external_version\": \"1.0\","
+      "    \"min_profile_created_by_version\": \"43.0.0.1\""
+      "  },"
+      "  \"cccccccccccccccccccccccccccccccc\": {"
+      "    \"external_crx\": \"RandomExtension3.crx\","
+      "    \"external_version\": \"3.0\","
+      "    \"min_profile_created_by_version\": \"44.0.0.1\""
+      "  }"
+      "}";
+  min_profile_created_by_version_visitor.profile()->GetPrefs()->SetString(
+      prefs::kProfileCreatedByVersion, "40.0.0.1");
+  EXPECT_EQ(0, min_profile_created_by_version_visitor.Visit(json_data));
+  min_profile_created_by_version_visitor.profile()->GetPrefs()->SetString(
+      prefs::kProfileCreatedByVersion, "43.0.0.1");
+  EXPECT_EQ(2, min_profile_created_by_version_visitor.Visit(json_data));
+  min_profile_created_by_version_visitor.profile()->GetPrefs()->SetString(
+      prefs::kProfileCreatedByVersion, "45.0.0.1");
+  EXPECT_EQ(3, min_profile_created_by_version_visitor.Visit(json_data));
+#endif  // OS_CHROMEOS
 }
 
 // Test loading good extensions from the profile directory.
 TEST_F(ExtensionServiceTest, LoadAndRelocalizeExtensions) {
   // Ensure we're testing in "en" and leave global state untouched.
   extension_l10n_util::ScopedLocaleForTest testLocale("en");
 
   // Initialize the test dir with a good Preferences/extensions.
   base::FilePath source_install_dir = data_dir().AppendASCII("l10n");
   base::FilePath pref_path =
@@ skipping 2225 matching lines @@
 
   service()->Observe(chrome::NOTIFICATION_PROFILE_DESTRUCTION_STARTED,
                      content::Source<Profile>(profile()),
                      content::NotificationService::NoDetails());
   EXPECT_EQ(UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN, unloaded_reason_);
   EXPECT_EQ(0u, registry()->enabled_extensions().size());
   EXPECT_EQ(0u, registry()->disabled_extensions().size());
   EXPECT_EQ(0u, registry()->terminated_extensions().size());
   EXPECT_EQ(0u, registry()->blacklisted_extensions().size());
 }