Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1128693004: Don't initialize decryptor on CDM creation failure (Closed)

Created:
5 years, 7 months ago by wdzierzanowski
Modified:
5 years, 7 months ago
Reviewers:
jrummell, ddorwin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't initialize decryptor on CDM creation failure PpapiDecryptor::Create() must not proceed with decryptor initialization if the CDM wrapper could not be created. PpapiDecryptor::PpapiDecryptor() asserts the CDM wrapper is valid and InitializeCdm() uses it unconditionally. BUG=488363 TEST=EME tests pass Committed: https://crrev.com/4590f922ab1449f86e8d4ad43047de47d7790610 Cr-Commit-Position: refs/heads/master@{#330150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/media/crypto/ppapi_decryptor.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wdzierzanowski
jrummell, PTAL. I think a return statement was needlessly removed in https://codereview.chromium.org/1102363005/diff/80001/content/renderer/media/crypto/ppapi_decryptor.cc.
5 years, 7 months ago (2015-05-15 10:57:35 UTC) #2
jrummell
lgtm. Thanks for fixing this.
5 years, 7 months ago (2015-05-15 17:00:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128693004/1
5 years, 7 months ago (2015-05-15 18:01:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 18:57:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:58:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4590f922ab1449f86e8d4ad43047de47d7790610
Cr-Commit-Position: refs/heads/master@{#330150}

Powered by Google App Engine
This is Rietveld 408576698