Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 112853004: Don't double-quote strings when passing them into GN args. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

Don't double-quote strings when passing them into GN args. Previously, both EscapeStringForGN and GetArgsStringForGN would add quotes. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gyp_chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
7 years ago (2013-12-16 22:04:34 UTC) #1
Finnur
7 years ago (2013-12-16 22:05:58 UTC) #2
LGTM, with nit.

Nit: No BUG specified.

Powered by Google App Engine
This is Rietveld 408576698