build/gyp_chromium - Issue 112853004: Don't double-quote strings when passing them into GN args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 112853004: Don't double-quote strings when passing them into GN args. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index 978ce4af5a3e8fb1bd88145bdcf7f5ef052de3b0..e8aee14af643d332b344167a64f6224a35a2b2de 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -129,7 +129,7 @@ def GetArgsStringForGN(supplemental_files):

# These string arguments get passed directly.

for v in ['windows_sdk_path']:

if v in vars_dict:

- gn_args += ' ' + v + '="' + EscapeStringForGN(vars_dict[v]) + '"'

+ gn_args += ' ' + v + '=' + EscapeStringForGN(vars_dict[v])

# Set the GYP flag so BUILD files know they're being invoked in GYP mode.

gn_args += ' is_gyp=true'

« no previous file with comments | « no previous file | no next file » | no next file with comments »