Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1128523002: Usage of ThreadTaskRunner in lieu of in [chrome/browser/sync],[components/sync_driver] (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/sync module & corresponding dependencies in components/sync_driver module MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/ac08132daccb3fa9ded31f89e037a9436d88d9b8 Cr-Commit-Position: refs/heads/master@{#328710}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -28 lines) Patch
M chrome/browser/sync/glue/frontend_data_type_controller.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_auth_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync_driver/data_type_controller.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M components/sync_driver/data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/fake_data_type_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/sync_driver/non_ui_data_type_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/non_ui_data_type_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/sync_driver/ui_data_type_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/ui_data_type_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Pranay
blundell@chromium.org: Please review changes in [components] module sky@chromium.org: Please review changes in [chrome/browser] module
5 years, 7 months ago (2015-05-05 09:51:24 UTC) #2
blundell
-blundell, sky zea@ is the best reviewer for this CL, since he is an OWNER ...
5 years, 7 months ago (2015-05-05 10:51:11 UTC) #4
Nicolas Zea
Mostly LG, but please forward declare base::SingleThreadTaskRunner when it's not actually being used. https://codereview.chromium.org/1128523002/diff/1/chrome/browser/sync/glue/frontend_data_type_controller.h File ...
5 years, 7 months ago (2015-05-06 00:09:06 UTC) #6
Pranay
Done https://codereview.chromium.org/1128523002/diff/1/chrome/browser/sync/glue/frontend_data_type_controller.h File chrome/browser/sync/glue/frontend_data_type_controller.h (right): https://codereview.chromium.org/1128523002/diff/1/chrome/browser/sync/glue/frontend_data_type_controller.h#newcode13 chrome/browser/sync/glue/frontend_data_type_controller.h:13: #include "base/single_thread_task_runner.h" On 2015/05/06 00:09:06, Nicolas Zea wrote: ...
5 years, 7 months ago (2015-05-06 03:47:33 UTC) #7
Pranay
PTAL
5 years, 7 months ago (2015-05-06 03:47:46 UTC) #8
Nicolas Zea
lgtm
5 years, 7 months ago (2015-05-06 23:13:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128523002/20001
5 years, 7 months ago (2015-05-07 02:42:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 04:56:55 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 04:58:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac08132daccb3fa9ded31f89e037a9436d88d9b8
Cr-Commit-Position: refs/heads/master@{#328710}

Powered by Google App Engine
This is Rietveld 408576698