components/sync_driver/data_type_controller.h - Issue 1128523002: Usage of ThreadTaskRunner in lieu of in [chrome/browser/sync],[components/sync_driver]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/data_type_controller.h

Issue 1128523002: Usage of ThreadTaskRunner in lieu of in [chrome/browser/sync],[components/sync_driver] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Review Comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc ('k') | components/sync_driver/data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/data_type_controller.h

diff --git a/components/sync_driver/data_type_controller.h b/components/sync_driver/data_type_controller.h

index 258e9b77ae5dd38763b80847645f5443494610cd..ab6a517f39878b15bcd35db8e0c749f9453d06b0 100644

--- a/components/sync_driver/data_type_controller.h

+++ b/components/sync_driver/data_type_controller.h

@@ -19,6 +19,10 @@

#include "sync/internal_api/public/engine/model_safe_worker.h"

#include "sync/internal_api/public/util/unrecoverable_error_handler.h"

+namespace base {

+class SingleThreadTaskRunner;

namespace syncer {

class SyncError;

struct UserShare;

@@ -150,7 +154,7 @@ class DataTypeController

friend class base::RefCountedDeleteOnMessageLoop<DataTypeController>;

friend class base::DeleteHelper<DataTypeController>;

- DataTypeController(scoped_refptr<base::MessageLoopProxy> ui_thread,

+ DataTypeController(scoped_refptr<base::SingleThreadTaskRunner> ui_thread,

const base::Closure& error_callback);

// If the DTC is waiting for models to load, once the models are