Make calls to AtomicString(const String&) explicit in dom/

Source/core/dom/ClassNodeList.h

Index: Source/core/dom/ClassNodeList.h
diff --git a/Source/core/dom/ClassNodeList.h b/Source/core/dom/ClassNodeList.h
index 2e08ea819288c606479a0d1664b800acdefecfd3..cc882e7c22198d383466c5aad37f6bc1b71ce104 100644
--- a/Source/core/dom/ClassNodeList.h
+++ b/Source/core/dom/ClassNodeList.h
@@ -39,8 +39,9 @@ namespace WebCore {
 
 class ClassNodeList FINAL : public LiveNodeList {
 public:
-    static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, const String& classNames)
+    static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, CollectionType type, const AtomicString& classNames)

[eseidel, 2013/12/15 16:51:26]

Odd that this would be AtomicString?  I guess it's stored in the DOM as the
class= attribute?

[Inactive, 2013/12/16 14:26:27]

Yes, I found it a bit weird as well. However, it does get converted to an
AtomicString anyway when we initialize the m_classNames member.
It is a SpaceSplitString and its constructor is defined as follows:
SpaceSplitString(const AtomicString& string, bool shouldFoldCase)

[eseidel, 2013/12/30 17:19:27]

I guess it's common for many elements to share the same set of class names, and
thus same m_classnames string.  So it's OK for it to be atomic.

     {
+        ASSERT_UNUSED(type, type == ClassNodeListType);
         return adoptRef(new ClassNodeList(rootNode, classNames));
     }
 
@@ -49,12 +50,12 @@ public:
     bool nodeMatchesInlined(Element*) const;
 
 private:
-    ClassNodeList(PassRefPtr<Node> rootNode, const String& classNames);
+    ClassNodeList(PassRefPtr<Node> rootNode, const AtomicString& classNames);
 
     virtual bool nodeMatches(Element*) const OVERRIDE;
 
     SpaceSplitString m_classNames;

[Inactive, 2013/12/16 14:26:27]

See this member.

-    String m_originalClassNames;
+    AtomicString m_originalClassNames;
 };
 
 inline bool ClassNodeList::nodeMatchesInlined(Element* testNode) const