Make calls to AtomicString(const String&) explicit in dom/

Source/core/dom/ClassNodeList.h

 /*
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2007 David Smith (catfish.man@gmail.com)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 21 matching lines @@
 
 #include "core/dom/Element.h"
 #include "core/dom/LiveNodeList.h"
 #include "core/dom/Node.h"
 #include "core/dom/SpaceSplitString.h"
 
 namespace WebCore {
 
 class ClassNodeList FINAL : public LiveNodeList {
 public:
-    static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, const String& classNames)
+    static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, CollectionType type, const AtomicString& classNames)

[eseidel, 2013/12/15 16:51:26]

Odd that this would be AtomicString?  I guess it's stored in the DOM as the
class= attribute?

[Inactive, 2013/12/16 14:26:27]

Yes, I found it a bit weird as well. However, it does get converted to an
AtomicString anyway when we initialize the m_classNames member.
It is a SpaceSplitString and its constructor is defined as follows:
SpaceSplitString(const AtomicString& string, bool shouldFoldCase)

[eseidel, 2013/12/30 17:19:27]

I guess it's common for many elements to share the same set of class names, and
thus same m_classnames string.  So it's OK for it to be atomic.

     {
+        ASSERT_UNUSED(type, type == ClassNodeListType);
         return adoptRef(new ClassNodeList(rootNode, classNames));
     }
 
     virtual ~ClassNodeList();
 
     bool nodeMatchesInlined(Element*) const;
 
 private:
-    ClassNodeList(PassRefPtr<Node> rootNode, const String& classNames);
+    ClassNodeList(PassRefPtr<Node> rootNode, const AtomicString& classNames);
 
     virtual bool nodeMatches(Element*) const OVERRIDE;
 
     SpaceSplitString m_classNames;

[Inactive, 2013/12/16 14:26:27]

See this member.

-    String m_originalClassNames;
+    AtomicString m_originalClassNames;
 };
 
 inline bool ClassNodeList::nodeMatchesInlined(Element* testNode) const
 {
     if (!testNode->hasClass())
         return false;
     if (!m_classNames.size())
         return false;
     // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
     // https://bugs.webkit.org/show_bug.cgi?id=94718
     if (!testNode->isStyledElement())
         return false;
     return testNode->classNames().containsAll(m_classNames);
 }
 
 } // namespace WebCore
 
 #endif // ClassNodeList_h