components/history/core/browser/history_backend.h - Issue 1128343004: Allow favicons for synced bookmarks to expire

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend.h

Issue 1128343004: Allow favicons for synced bookmarks to expire (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_backend.h

diff --git a/components/history/core/browser/history_backend.h b/components/history/core/browser/history_backend.h

index 476008d2326924bb75ae012fa9f48dc002eedd54..da235b3c0136b5f6fe282c6c3ea6a309e05957b9 100644

--- a/components/history/core/browser/history_backend.h

+++ b/components/history/core/browser/history_backend.h

@@ -492,6 +492,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,

MergeFaviconMaxFaviconBitmapsPerIconURL);

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,

+ MergeIdenticalFaviconDoesNotChangeLastUpdatedTime);

+ FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,

UpdateFaviconMappingsAndFetchMultipleIconTypes);

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, GetFaviconsFromDBEmpty);

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,