Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: components/history/core/browser/history_backend.cc

Issue 1128343004: Allow favicons for synced bookmarks to expire (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_backend.cc
diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc
index faf00c6db8293356065862bd9fdc5e72a72ba4c8..5fe742030d9da65ea61a718e7d2d16f4403c0f7a 100644
--- a/components/history/core/browser/history_backend.cc
+++ b/components/history/core/browser/history_backend.cc
@@ -1603,8 +1603,12 @@ void HistoryBackend::MergeFavicon(
for (size_t i = 0; i < bitmap_id_sizes.size(); ++i) {
if (bitmap_id_sizes[i].pixel_size == pixel_size) {
if (IsFaviconBitmapDataEqual(bitmap_id_sizes[i].bitmap_id, bitmap_data)) {
- thumbnail_db_->SetFaviconBitmapLastUpdateTime(
- bitmap_id_sizes[i].bitmap_id, base::Time::Now());
+ // Sync calls MergeFavicon() for all of the favicons that it manages at
+ // startup. Do not update the "last updated" time if the favicon bitmap
+ // data matches that in the database.
+ // TODO: Pass in boolean to MergeFavicon() if any users of
+ // MergeFavicon() want the last_updated time to be updated when the new
+ // bitmap data is identical to the old.
bitmap_identical = true;
} else {
// Expire the favicon bitmap because sync can provide incorrect
« no previous file with comments | « components/history/core/browser/history_backend.h ('k') | components/history/core/browser/history_backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698