Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.h

Issue 1128273005: Devtools: Move runMessageLoopOnPause and other methods on ScriptDebugServer::Client (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix ownptrs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptDebugServer.h
diff --git a/Source/bindings/core/v8/ScriptDebugServer.h b/Source/bindings/core/v8/ScriptDebugServer.h
index e36f91444a1cbf44797690f3042c7f22799c04e3..588546f0abf5a623d617d0cd24346e5f65c01408 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.h
+++ b/Source/bindings/core/v8/ScriptDebugServer.h
@@ -57,6 +57,9 @@ public:
public:
virtual ~Client() { }
virtual v8::Local<v8::Object> compileDebuggerScript() = 0;
+ virtual ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) = 0;
+ virtual void runMessageLoopOnPause(v8::Local<v8::Context>) = 0;
+ virtual void quitMessageLoopOnPause() = 0;
};
void enable();
@@ -118,13 +121,7 @@ public:
v8::MaybeLocal<v8::Value> setFunctionVariableValue(v8::Local<v8::Value> functionValue, int scopeNumber, const String& variableName, v8::Local<v8::Value> newValue);
v8::Isolate* isolate() const { return m_isolate; }
-
-protected:
- ScriptDebugServer(v8::Isolate*, PassOwnPtr<Client>);
-
- virtual ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) = 0;
- virtual void runMessageLoopOnPause(v8::Local<v8::Context>) = 0;
- virtual void quitMessageLoopOnPause() = 0;
+ explicit ScriptDebugServer(v8::Isolate*, Client*);
private:
void compileDebuggerScript();
@@ -155,7 +152,7 @@ private:
void handleV8PromiseEvent(ScriptDebugListener*, ScriptState* pausedScriptState, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);
v8::Isolate* m_isolate;
- OwnPtr<Client> m_client;
+ Client* m_client;
bool m_breakpointsActivated;
v8::UniquePersistent<v8::FunctionTemplate> m_breakProgramCallbackTemplate;
v8::UniquePersistent<v8::Object> m_debuggerScript;

Powered by Google App Engine
This is Rietveld 408576698