Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1128233008: [es6] Iterators and generators should "extend" %IteratorPrototype% (Closed)

Created:
5 years, 7 months ago by arv (Not doing code reviews)
Modified:
5 years, 7 months ago
Reviewers:
wingo, adamk
CC:
v8-dev, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Iterators and generators should "extend" %IteratorPrototype% All the builtin iterators as well as the generator objects have an object called %IteratorPrototype% in the spec between them and %ObjectPrototype%. BUG=v8:3568 LOG=N Committed: https://crrev.com/834a8e9f637c175ad214a06aa6a262b73a90627d Cr-Commit-Position: refs/heads/master@{#28426}

Patch Set 1 #

Patch Set 2 : Add missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -53 lines) Patch
M BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M src/array-iterator.js View 2 chunks +1 line, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/collection-iterator.js View 5 chunks +2 lines, -19 lines 0 comments Download
M src/generator.js View 2 chunks +0 lines, -8 lines 0 comments Download
A src/iterator-prototype.js View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/string-iterator.js View 3 chunks +1 line, -11 lines 0 comments Download
M test/mjsunit/es6/generators-runtime.js View 3 chunks +2 lines, -11 lines 0 comments Download
A test/mjsunit/es6/iterator-prototype.js View 1 1 chunk +58 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
arv (Not doing code reviews)
PTAL
5 years, 7 months ago (2015-05-14 22:22:52 UTC) #2
arv (Not doing code reviews)
Add missing files
5 years, 7 months ago (2015-05-14 22:26:24 UTC) #3
wingo
lgtm
5 years, 7 months ago (2015-05-15 15:04:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128233008/20001
5 years, 7 months ago (2015-05-15 15:07:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 15:09:55 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 15:10:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/834a8e9f637c175ad214a06aa6a262b73a90627d
Cr-Commit-Position: refs/heads/master@{#28426}

Powered by Google App Engine
This is Rietveld 408576698