src/generator.js - Issue 1128233008: [es6] Iterators and generators should "extend" %IteratorPrototype%

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/generator.js

Issue 1128233008: [es6] Iterators and generators should "extend" %IteratorPrototype% (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add missing files Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/generator.js

diff --git a/src/generator.js b/src/generator.js

index ae34ed3a4b4b266720c10372219af91894030596..ef276da50b93021ef7a4417fd447f612a4df6446 100644

--- a/src/generator.js

+++ b/src/generator.js

@@ -66,11 +66,6 @@ function GeneratorObjectThrow(exn) {

}

-function GeneratorObjectIterator() {

- return this;

function GeneratorFunctionConstructor(arg1) { // length == 1

var source = $newFunctionString(arguments, 'function*');

var global_proxy = %GlobalProxy(GeneratorFunctionConstructor);

@@ -95,9 +90,6 @@ $installFunctions(GeneratorObjectPrototype,

["next", GeneratorObjectNext,

"throw", GeneratorObjectThrow]);

-$setFunctionName(GeneratorObjectIterator, symbolIterator);

-%AddNamedProperty(GeneratorObjectPrototype, symbolIterator,

- GeneratorObjectIterator, DONT_ENUM | DONT_DELETE | READ_ONLY);

%AddNamedProperty(GeneratorObjectPrototype, "constructor",

GeneratorFunctionPrototype, DONT_ENUM | READ_ONLY);

%AddNamedProperty(GeneratorObjectPrototype,

« no previous file with comments | « src/collection-iterator.js ('k') | src/iterator-prototype.js » ('j') | no next file with comments »