Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: base/containers/hash_tables_unittest.cc

Issue 1128203010: base: Remove the remaining usage GG_(U)INTn_C macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/rand_util.cc » ('j') | base/time/time_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/containers/hash_tables_unittest.cc
diff --git a/base/containers/hash_tables_unittest.cc b/base/containers/hash_tables_unittest.cc
index 60fbeaabc099c7cd967ac5c6c6409160fa0413cf..dd77ac9b1109e2b57985b71d01c984b6f2d055f9 100644
--- a/base/containers/hash_tables_unittest.cc
+++ b/base/containers/hash_tables_unittest.cc
@@ -4,6 +4,8 @@
#include "base/containers/hash_tables.h"
+#include <stdint.h>
+
danakj 2015/05/14 22:27:52 no whitespace here https://google-styleguide.googl
tfarina 2015/05/18 17:09:01 Done.
#include <string>
#include "base/basictypes.h"
viettrungluu 2015/05/14 21:32:33 You can probably remove this include.
tfarina 2015/05/18 17:09:01 not yet, as it is still using the int* types from
@@ -31,7 +33,7 @@ TEST_F(HashPairTest, IntegerPairs) {
INSERT_PAIR_TEST(Int16Int16Pair, 4, 6);
INSERT_PAIR_TEST(Int16Int32Pair, 9, (1 << 29) + 378128932);
INSERT_PAIR_TEST(Int16Int64Pair, 10,
- (GG_INT64_C(1) << 60) + GG_INT64_C(78931732321));
+ (INT64_C(1) << 60) + INT64_C(78931732321));
typedef std::pair<int32, int16> Int32Int16Pair;
typedef std::pair<int32, int32> Int32Int32Pair;
@@ -40,7 +42,7 @@ TEST_F(HashPairTest, IntegerPairs) {
INSERT_PAIR_TEST(Int32Int16Pair, 4, 6);
INSERT_PAIR_TEST(Int32Int32Pair, 9, (1 << 29) + 378128932);
INSERT_PAIR_TEST(Int32Int64Pair, 10,
- (GG_INT64_C(1) << 60) + GG_INT64_C(78931732321));
+ (INT64_C(1) << 60) + INT64_C(78931732321));
typedef std::pair<int64, int16> Int64Int16Pair;
typedef std::pair<int64, int32> Int64Int32Pair;
@@ -49,7 +51,7 @@ TEST_F(HashPairTest, IntegerPairs) {
INSERT_PAIR_TEST(Int64Int16Pair, 4, 6);
INSERT_PAIR_TEST(Int64Int32Pair, 9, (1 << 29) + 378128932);
INSERT_PAIR_TEST(Int64Int64Pair, 10,
- (GG_INT64_C(1) << 60) + GG_INT64_C(78931732321));
+ (INT64_C(1) << 60) + INT64_C(78931732321));
}
// Verify that base::hash_set<const char*> compares by pointer value, not as C
« no previous file with comments | « no previous file | base/rand_util.cc » ('j') | base/time/time_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698