Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: base/containers/hash_tables_unittest.cc

Issue 1128203010: base: Remove the remaining usage GG_(U)INTn_C macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/rand_util.cc » ('j') | base/time/time_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/containers/hash_tables.h" 5 #include "base/containers/hash_tables.h"
6 6
7 #include <stdint.h>
8
danakj 2015/05/14 22:27:52 no whitespace here https://google-styleguide.googl
tfarina 2015/05/18 17:09:01 Done.
7 #include <string> 9 #include <string>
8 10
9 #include "base/basictypes.h" 11 #include "base/basictypes.h"
viettrungluu 2015/05/14 21:32:33 You can probably remove this include.
tfarina 2015/05/18 17:09:01 not yet, as it is still using the int* types from
10 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
11 13
12 namespace { 14 namespace {
13 15
14 class HashPairTest : public testing::Test { 16 class HashPairTest : public testing::Test {
15 }; 17 };
16 18
17 #define INSERT_PAIR_TEST(Type, value1, value2) \ 19 #define INSERT_PAIR_TEST(Type, value1, value2) \
18 { \ 20 { \
19 Type pair(value1, value2); \ 21 Type pair(value1, value2); \
20 base::hash_map<Type, int> map; \ 22 base::hash_map<Type, int> map; \
21 map[pair] = 1; \ 23 map[pair] = 1; \
22 } 24 }
23 25
24 // Verify that a hash_map can be constructed for pairs of integers of various 26 // Verify that a hash_map can be constructed for pairs of integers of various
25 // sizes. 27 // sizes.
26 TEST_F(HashPairTest, IntegerPairs) { 28 TEST_F(HashPairTest, IntegerPairs) {
27 typedef std::pair<int16, int16> Int16Int16Pair; 29 typedef std::pair<int16, int16> Int16Int16Pair;
28 typedef std::pair<int16, int32> Int16Int32Pair; 30 typedef std::pair<int16, int32> Int16Int32Pair;
29 typedef std::pair<int16, int64> Int16Int64Pair; 31 typedef std::pair<int16, int64> Int16Int64Pair;
30 32
31 INSERT_PAIR_TEST(Int16Int16Pair, 4, 6); 33 INSERT_PAIR_TEST(Int16Int16Pair, 4, 6);
32 INSERT_PAIR_TEST(Int16Int32Pair, 9, (1 << 29) + 378128932); 34 INSERT_PAIR_TEST(Int16Int32Pair, 9, (1 << 29) + 378128932);
33 INSERT_PAIR_TEST(Int16Int64Pair, 10, 35 INSERT_PAIR_TEST(Int16Int64Pair, 10,
34 (GG_INT64_C(1) << 60) + GG_INT64_C(78931732321)); 36 (INT64_C(1) << 60) + INT64_C(78931732321));
35 37
36 typedef std::pair<int32, int16> Int32Int16Pair; 38 typedef std::pair<int32, int16> Int32Int16Pair;
37 typedef std::pair<int32, int32> Int32Int32Pair; 39 typedef std::pair<int32, int32> Int32Int32Pair;
38 typedef std::pair<int32, int64> Int32Int64Pair; 40 typedef std::pair<int32, int64> Int32Int64Pair;
39 41
40 INSERT_PAIR_TEST(Int32Int16Pair, 4, 6); 42 INSERT_PAIR_TEST(Int32Int16Pair, 4, 6);
41 INSERT_PAIR_TEST(Int32Int32Pair, 9, (1 << 29) + 378128932); 43 INSERT_PAIR_TEST(Int32Int32Pair, 9, (1 << 29) + 378128932);
42 INSERT_PAIR_TEST(Int32Int64Pair, 10, 44 INSERT_PAIR_TEST(Int32Int64Pair, 10,
43 (GG_INT64_C(1) << 60) + GG_INT64_C(78931732321)); 45 (INT64_C(1) << 60) + INT64_C(78931732321));
44 46
45 typedef std::pair<int64, int16> Int64Int16Pair; 47 typedef std::pair<int64, int16> Int64Int16Pair;
46 typedef std::pair<int64, int32> Int64Int32Pair; 48 typedef std::pair<int64, int32> Int64Int32Pair;
47 typedef std::pair<int64, int64> Int64Int64Pair; 49 typedef std::pair<int64, int64> Int64Int64Pair;
48 50
49 INSERT_PAIR_TEST(Int64Int16Pair, 4, 6); 51 INSERT_PAIR_TEST(Int64Int16Pair, 4, 6);
50 INSERT_PAIR_TEST(Int64Int32Pair, 9, (1 << 29) + 378128932); 52 INSERT_PAIR_TEST(Int64Int32Pair, 9, (1 << 29) + 378128932);
51 INSERT_PAIR_TEST(Int64Int64Pair, 10, 53 INSERT_PAIR_TEST(Int64Int64Pair, 10,
52 (GG_INT64_C(1) << 60) + GG_INT64_C(78931732321)); 54 (INT64_C(1) << 60) + INT64_C(78931732321));
53 } 55 }
54 56
55 // Verify that base::hash_set<const char*> compares by pointer value, not as C 57 // Verify that base::hash_set<const char*> compares by pointer value, not as C
56 // strings. 58 // strings.
57 TEST(HashTableTest, CharPointers) { 59 TEST(HashTableTest, CharPointers) {
58 std::string str1("hello"); 60 std::string str1("hello");
59 std::string str2("hello"); 61 std::string str2("hello");
60 base::hash_set<const char*> set; 62 base::hash_set<const char*> set;
61 63
62 set.insert(str1.c_str()); 64 set.insert(str1.c_str());
63 EXPECT_EQ(1u, set.count(str1.c_str())); 65 EXPECT_EQ(1u, set.count(str1.c_str()));
64 EXPECT_EQ(0u, set.count(str2.c_str())); 66 EXPECT_EQ(0u, set.count(str2.c_str()));
65 } 67 }
66 68
67 } // namespace 69 } // namespace
OLDNEW
« no previous file with comments | « no previous file | base/rand_util.cc » ('j') | base/time/time_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698