Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1128143002: [es6] Fix symbol comparison on some architectures (Closed)

Created:
5 years, 7 months ago by conradw
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix symbol comparison on some architectures https://codereview.chromium.org/1125783002 did not handle all cases for some architectures. These cases are now covered, and tests have been extended to check them. BUG=v8:4073 LOG=N Committed: https://crrev.com/382435480d682ea35c804c954ffc6f4fef78346b Cr-Commit-Position: refs/heads/master@{#28266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +17 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
conradw
PTAL - currently the extended test fails on the affected architectures.
5 years, 7 months ago (2015-05-06 14:43:01 UTC) #2
arv (Not doing code reviews)
LGTM For once I actually ran the test on all platforms and still I missed ...
5 years, 7 months ago (2015-05-06 14:54:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128143002/1
5 years, 7 months ago (2015-05-06 14:57:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2501)
5 years, 7 months ago (2015-05-06 15:01:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128143002/1
5 years, 7 months ago (2015-05-06 15:02:56 UTC) #9
conradw
On 2015/05/06 14:54:35, arv wrote: > LGTM > > For once I actually ran the ...
5 years, 7 months ago (2015-05-06 15:03:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 15:04:45 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 15:04:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/382435480d682ea35c804c954ffc6f4fef78346b
Cr-Commit-Position: refs/heads/master@{#28266}

Powered by Google App Engine
This is Rietveld 408576698