Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1125783002: [es6] When comparing two symbols we may need to throw a TypeError (Closed)

Created:
5 years, 7 months ago by arv (Not doing code reviews)
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] When comparing two symbols we may need to throw a TypeError When comparing a symbol to istself using <, <=, > or >= we need to throw a TypeError. This is correctly handled in the runtime function so if we are comparing a symbol fall back to use the runtime. BUG=v8:4073 LOG=Y R=rossberg@chromium.org Committed: https://crrev.com/d26f5d392317dcf1eef3693eadfa1b95a8850df8 Cr-Commit-Position: refs/heads/master@{#28226}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 7 months ago (2015-05-04 19:51:13 UTC) #1
rossberg
lgtm
5 years, 7 months ago (2015-05-05 14:02:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125783002/20001
5 years, 7 months ago (2015-05-05 14:08:39 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 14:11:52 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 14:18:09 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d26f5d392317dcf1eef3693eadfa1b95a8850df8
Cr-Commit-Position: refs/heads/master@{#28226}

Powered by Google App Engine
This is Rietveld 408576698