Make GrStrokeInfo inherit from SkStrokeRec

Make GrStrokeInfo inherit from SkStrokeRec

Make the code more readable by inheriting GrStrokeInfo from SkStrokeRec.
This should avoid the long .getStrokeRec() and .getStrokeRecPtr(). These
were a bit cumbersome especially in cases where an alias variable was
created for these, and then the reader had to keep track to which
StrokeInfo member the StrokeRec alias was pointing.

Removes SkStrokeRec::SkStrokeRec(const SkStrokeRec&). It was memcpying.
Try to play it safe wrt compiler using the possible padding of
superclass for subclass members. Instead, let the compiler generate
the copy constructor. Assignment operator was already
compiler-generated, so at least in that way this is consistent.

Renames GrStrokeInfo::applyDash to applyDashToPath for consistency
with superclass applyToPath.

Committed: https://skia.googlesource.com/skia/+/d156d36af871c23ce471a18764f4597f09cfca95

[Kimmo Kinnunen, 2015-05-08 06:53:31]

kkinnunen@nvidia.com changed reviewers:
+ egdaniel@google.com

[Kimmo Kinnunen, 2015-05-08 06:53:31]

Would this be useful, or was this sort of inheritance frowned upon? I find it
sort of natural, e.g. GrStrokeInfo is a kind of stroke info record that contains
a bit more properties than the original one. Of course, inheritance has
pitfalls..

FWIW, in the original GrStrokeInfo review bsalomon mentioned that he disliked
the .getStrokeRecPtr()

[Kimmo Kinnunen, 2015-05-15 13:19:39]

This would be ready for review

[egdaniel, 2015-05-15 14:07:05]

https://codereview.chromium.org/1128113008/diff/80001/src/gpu/GrStrokeInfo.h
File src/gpu/GrStrokeInfo.h (right):

https://codereview.chromium.org/1128113008/diff/80001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:137: bool operator==(const SkStrokeRec& other) const;
you declare these comparison operators but never actually define (or use?) them.

[Kimmo Kinnunen, 2015-05-18 06:18:36]

https://codereview.chromium.org/1128113008/diff/80001/src/gpu/GrStrokeInfo.h
File src/gpu/GrStrokeInfo.h (right):

https://codereview.chromium.org/1128113008/diff/80001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:137: bool operator==(const SkStrokeRec& other) const;
On 2015/05/15 14:07:05, egdaniel wrote:
> you declare these comparison operators but never actually define (or use?)
them.

Ah, sorry about that.
Done.

[egdaniel, 2015-05-18 13:34:36]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com

[egdaniel, 2015-05-18 13:34:36]

lgtm, adding brian for API

[bsalomon, 2015-05-18 13:45:07]

lgtm

[Kimmo Kinnunen, 2015-05-19 05:17:13]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-05-19 05:17:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128113008/100001

[commit-bot: I haz the power, 2015-05-19 05:23:59]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/d156d36af871c23ce471a18764f4597f09cfca95