Issue 1128103009: [Effen] Start removing 'position'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1128103009: [Effen] Start removing 'position'. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Effen] Start removing 'position'. This creates a new RenderNode class that does positioning. It then creates an fn Container class that uses it just to position things at 0,0 at the full extent of the container. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d184d5db73280ae236a3a3b60caa1694752f9b46

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -12 lines)			Patch
M	sky/framework/components/drawer.dart	View	2 chunks	+3 lines, -12 lines	0 comments	Download
M	sky/framework/fn.dart	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	sky/framework/layout.dart	View	1 chunk	+57 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 7 months ago (2015-05-15 23:39:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d184d5db73280ae236a3a3b60caa1694752f9b46 (presubmit successful).