Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: sky/framework/components/drawer.dart

Issue 1128103009: [Effen] Start removing 'position'. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/framework/fn.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/drawer.dart
diff --git a/sky/framework/components/drawer.dart b/sky/framework/components/drawer.dart
index b1e1a1be975b3bd7080600800967203b5973c8f0..5959bab73c4c11753120738a7bcf340061bc336d 100644
--- a/sky/framework/components/drawer.dart
+++ b/sky/framework/components/drawer.dart
@@ -97,22 +97,13 @@ class Drawer extends AnimatedComponent {
static final Style _maskStyle = new Style('''
background-color: black;
- will-change: opacity;
- position: absolute;
- top: 0;
- left: 0;
- bottom: 0;
- right: 0;'''
+ will-change: opacity;'''
);
static final Style _contentStyle = new Style('''
background-color: ${Grey[50]};
will-change: transform;
- position: absolute;
- width: ${_kWidth}px;
- top: 0;
- left: 0;
- bottom: 0;'''
+ width: ${_kWidth}px;'''
);
List<UINode> children;
@@ -152,7 +143,7 @@ class Drawer extends AnimatedComponent {
level: level);
return new EventListenerNode(
- new Container(
+ new FillStackContainer(
style: _style,
children: [ mask, content ]
),
« no previous file with comments | « no previous file | sky/framework/fn.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698