Update setting of Compositor on new root Layer

Update setting of Compositor on new root Layer

When calling LayerOwner::RecreateLayer() on the root Layer, the Compositor gets
moved to the new layer after all children are added.

If there are ongoing animations while this occurs they are cancelled. If any
animation observer attempts to access the compositor in response it will crash
Chrome as the compositor is null.

Update LayerOwner::RecreateLayer() to set the Compositor on the new root layer
bfore adding children. This also brings it to the same timing as when the
compositor would be set while performing RecreateLayer on non-root layers.

TEST=LayerOwnerTestWithCompositor.RecreateRootLayerDuringAnimation,
compositor_unittests, ash_unittests, views_unittests
BUG=chrome-os-partner:40032
Committed: https://crrev.com/3a4071534bad6ed913581340d143bd687b2fe57f
Cr-Commit-Position: refs/heads/master@{#329446}

[jonross, 2015-05-12 15:39:35]

Patchset #1 (id:1) has been deleted

[jonross, 2015-05-12 15:40:40]

jonross@chromium.org changed reviewers:
+ danakj@chromium.org

[jonross, 2015-05-12 15:40:41]

Hi Dana,

Could you provide a review of this change?

I've updated LayerOwner::RecreateLayer to set the new Compositor on a root layer
before adding its children.

Thanks,
Jon

[danakj, 2015-05-12 16:57:40]

LGTM

https://codereview.chromium.org/1128103003/diff/20001/ui/compositor/layer_own...
File ui/compositor/layer_owner_unittest.cc (right):

https://codereview.chromium.org/1128103003/diff/20001/ui/compositor/layer_own...
ui/compositor/layer_owner_unittest.cc:132: TEST_F(LayerOwnerTestWithCompositor,
RecreateRootLayerDuringAnimation) {
Would you mind adding a test for a non-root layer too while you're doing this?

https://codereview.chromium.org/1128103003/diff/20001/ui/compositor/layer_own...
ui/compositor/layer_owner_unittest.cc:138: Layer* child = new Layer;
does this test leak the layer? i think so, can you put it in scoped_ptr?

[jonross, 2015-05-12 17:26:25]

https://codereview.chromium.org/1128103003/diff/20001/ui/compositor/layer_own...
File ui/compositor/layer_owner_unittest.cc (right):

https://codereview.chromium.org/1128103003/diff/20001/ui/compositor/layer_own...
ui/compositor/layer_owner_unittest.cc:132: TEST_F(LayerOwnerTestWithCompositor,
RecreateRootLayerDuringAnimation) {
On 2015/05/12 16:57:40, danakj wrote:
> Would you mind adding a test for a non-root layer too while you're doing this?

Done.

https://codereview.chromium.org/1128103003/diff/20001/ui/compositor/layer_own...
ui/compositor/layer_owner_unittest.cc:138: Layer* child = new Layer;
On 2015/05/12 16:57:39, danakj wrote:
> does this test leak the layer? i think so, can you put it in scoped_ptr?

Done.

[jonross, 2015-05-12 17:26:50]

The CQ bit was checked by jonross@chromium.org

[jonross, 2015-05-12 17:26:50]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1128103003/#ps40001
(title: "Update tests")

[commit-bot: I haz the power, 2015-05-12 17:26:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128103003/40001

[commit-bot: I haz the power, 2015-05-12 18:18:49]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-05-12 18:19:39]

Patchset 2 (id:??) landed as
https://crrev.com/3a4071534bad6ed913581340d143bd687b2fe57f
Cr-Commit-Position: refs/heads/master@{#329446}