Converted bare pointer to scoped_ptr in net/url_request

Converted bare pointer to scoped_ptr in net/url_request

BUG=479898
Committed: https://crrev.com/49d649a34d1a75fc713d333316ef71b098e18df9
Cr-Commit-Position: refs/heads/master@{#329365}

[payal.pandey, 2015-05-08 14:48:15]

payal.pandey@samsung.com changed reviewers:
+ eroman@chromium.org

[payal.pandey, 2015-05-08 14:48:15]

Please have a look, Thanks

[eroman, 2015-05-08 18:59:47]

lgtm

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
net/url_request/url_request.cc:282: base::Value* URLRequest::GetStateAsValue()
const {
To complete this, please also make GetStateAsValue() return a scoped_ptr<>

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
File net/url_request/url_request_job.cc (right):

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
net/url_request/url_request_job.cc:29: base::Value* FiltersSetCallback(Filter*
filter,
Same thing here

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
File net/url_request/url_request_throttler_entry.cc (right):

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
net/url_request/url_request_throttler_entry.cc:55: base::Value*
NetLogRejectedRequestCallback(
Making this return a scoped_ptr<> is part of bug 472381

[payal.pandey, 2015-05-11 12:24:23]

Thanks for lgtm.
Please have a look again, for the changes incorporated as per review comments.


https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
 net/url_request/url_request.cc:282: base::Value* URLRequest::GetStateAsValue()
 const {
 To complete this, please also make GetStateAsValue() return a scoped_ptr<>

-> DONE
 


https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
 net/url_request/url_request_job.cc:29: base::Value* FiltersSetCallback(Filter*
 filter,
 Same thing here

->As FiltersSetCallback is not single argument functor, so not able to use in
Bind() as scoped_ptr returning function.



https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
 net/url_request/url_request_throttler_entry.cc:55: base::Value*
 NetLogRejectedRequestCallback(
 Making this return a scoped_ptr<> is part of bug 472381

->Will Update this as new CL for the bug mentioned.

Thanks.

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
net/url_request/url_request.cc:282: base::Value* URLRequest::GetStateAsValue()
const {
On 2015/05/08 18:59:47, eroman wrote:
> To complete this, please also make GetStateAsValue() return a scoped_ptr<>

Done.

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
File net/url_request/url_request_job.cc (right):

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
net/url_request/url_request_job.cc:29: base::Value* FiltersSetCallback(Filter*
filter,
On 2015/05/08 18:59:47, eroman wrote:
> Same thing here

As FiltersSetCallback is not single argument functor, so not able to use in
Bind() as scoped_ptr returning function.

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
File net/url_request/url_request_throttler_entry.cc (right):

https://codereview.chromium.org/1128083003/diff/1/net/url_request/url_request...
net/url_request/url_request_throttler_entry.cc:55: base::Value*
NetLogRejectedRequestCallback(
On 2015/05/08 18:59:47, eroman wrote:
> Making this return a scoped_ptr<> is part of bug 472381

Will Update this as new CL for the bug mentioned.

[eroman, 2015-05-11 19:00:07]

lgtm

https://codereview.chromium.org/1128083003/diff/20001/net/url_request/url_req...
File net/url_request/url_request.h (right):

https://codereview.chromium.org/1128083003/diff/20001/net/url_request/url_req...
net/url_request/url_request.h:367: // debugging.  Caller takes ownership of
returned value.
Delete the comment "Caller takes ownership of returned value."
(This is already explicit from the scoped_ptr<> return type.)

[eroman, 2015-05-11 21:19:50]

Also fix the description:

poniter --> pointer

[payal.pandey, 2015-05-12 05:15:08]

On 2015/05/11 21:19:50, eroman wrote:
> Also fix the description:
> 
> poniter --> pointer

[payal.pandey, 2015-05-12 05:16:48]

On 2015/05/12 05:15:08, payal.pandey wrote:
> On 2015/05/11 21:19:50, eroman wrote:
> > Also fix the description:
> > 
> > poniter --> pointer

Not able to get this point properly, Please brief.

[eroman, 2015-05-12 05:22:13]

There is a spelling mistake in the description. Instead of "poniter" you should
write "pointer"

[payal.pandey, 2015-05-12 05:38:08]

On 2015/05/12 05:22:13, eroman wrote:
> There is a spelling mistake in the description. Instead of "poniter" you
should
> write "pointer"

Sorry I dint found the "poniter" in any description.

[payal.pandey, 2015-05-12 05:50:29]

The CQ bit was checked by payal.pandey@samsung.com

[payal.pandey, 2015-05-12 05:50:30]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1128083003/#ps40001
(title: "Deleted the comment desciption.")

[commit-bot: I haz the power, 2015-05-12 05:51:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128083003/40001

[eroman, 2015-05-12 05:52:05]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2015-05-12 05:52:35]

I have included a picture to help you understand:
http://i.imgur.com/HXxdW8f.png

Fix the spelling before submitting

[payal.pandey, 2015-05-12 05:54:12]

On 2015/05/12 05:52:35, eroman wrote:
> I have included a picture to help you understand:
> http://i.imgur.com/HXxdW8f.png
> 
> Fix the spelling before submitting

Ohhh, that was so silly one.
Thanks.

[payal.pandey, 2015-05-12 05:54:32]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-05-12 05:55:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128083003/40001

[commit-bot: I haz the power, 2015-05-12 06:49:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-12 06:50:17]

Patchset 3 (id:??) landed as
https://crrev.com/49d649a34d1a75fc713d333316ef71b098e18df9
Cr-Commit-Position: refs/heads/master@{#329365}