Converted bare pointer to scoped_ptr in net/url_request

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 261 matching lines @@
   if (calling_delegate_ || !blocked_by_.empty()) {
     return LoadStateWithParam(
         LOAD_STATE_WAITING_FOR_DELEGATE,
         use_blocked_by_as_load_param_ ? base::UTF8ToUTF16(blocked_by_) :
                                         base::string16());
   }
   return LoadStateWithParam(job_.get() ? job_->GetLoadState() : LOAD_STATE_IDLE,
                             base::string16());
 }
 
 base::Value* URLRequest::GetStateAsValue() const {

[eroman, 2015/05/08 18:59:47]

To complete this, please also make GetStateAsValue() return a scoped_ptr<>

[payal.pandey, 2015/05/11 12:24:23]

Done.

-  base::DictionaryValue* dict = new base::DictionaryValue();
+  scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
   dict->SetString("url", original_url().possibly_invalid_spec());
 
   if (url_chain_.size() > 1) {
     scoped_ptr<base::ListValue> list(new base::ListValue());
     for (const GURL& url : url_chain_) {
       list->AppendString(url.possibly_invalid_spec());
     }
     dict->Set("url_chain", list.Pass());
   }
 
@@ skipping 22 matching lines @@
       break;
     case URLRequestStatus::CANCELED:
       dict->SetString("status", "CANCELED");
       break;
     case URLRequestStatus::FAILED:
       dict->SetString("status", "FAILED");
       break;
   }
   if (status_.error() != OK)
     dict->SetInteger("net_error", status_.error());
-  return dict;
+  return dict.release();
 }
 
 void URLRequest::LogBlockedBy(const char* blocked_by) {
   DCHECK(blocked_by);
   DCHECK_GT(strlen(blocked_by), 0u);
 
   // Only log information to NetLog during startup and certain deferring calls
   // to delegates.  For all reads but the first, do nothing.
   if (!calling_delegate_ && !response_info_.request_time.is_null())
     return;
@@ skipping 846 matching lines @@
       new base::debug::StackTrace(NULL, 0);
   *stack_trace_copy = stack_trace;
   stack_trace_.reset(stack_trace_copy);
 }
 
 const base::debug::StackTrace* URLRequest::stack_trace() const {
   return stack_trace_.get();
 }
 
 }  // namespace net