[Smart Lock] Make link from brading string (Google Smart Lock) in save password infobar.

[Smart Lock] Brading string (Google Smart Lock) in save password infobar should be link to help center article.

Google Smart Lock in save password infobar should be a link to help
center article. Link is open in new tab, infobar is not dismissed when
link is clicked.

BUG=454815, 486739
Committed: https://crrev.com/e12f37ab81281d683bfb36b37e089e80fefc9a01
Cr-Commit-Position: refs/heads/master@{#329737}

[melandory, 2015-05-12 12:42:29]

Patchset #1 (id:1) has been deleted

[melandory, 2015-05-13 11:29:27]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2015-05-13 11:29:28]

Hi Vaclav,

can you look at changes in:

save_password_infobar_delegate.h
save_password_infobar_delegate.cc

Thanks in advance.

[vabr (Chromium), 2015-05-13 13:18:05]

LGTM!
Vaclav

[melandory, 2015-05-13 13:40:49]

melandory@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[melandory, 2015-05-13 13:40:50]

Hi Dan,

do you have time to look to this CL (We want to have this fix in M44?


Thanks in advance.

[gone, 2015-05-13 18:33:25]

lgtm

https://codereview.chromium.org/1128073003/diff/40001/chrome/browser/password...
File chrome/browser/password_manager/save_password_infobar_delegate.h (right):

https://codereview.chromium.org/1128073003/diff/40001/chrome/browser/password...
chrome/browser/password_manager/save_password_infobar_delegate.h:95: // If title
contains Google Smart Lock, then it should be link to help center
nit: add blank line above

Maybe:
If set, describes the location of the link to the help center article for Smart
Lock.

?

[melandory, 2015-05-13 22:30:04]

https://codereview.chromium.org/1128073003/diff/40001/chrome/browser/password...
File chrome/browser/password_manager/save_password_infobar_delegate.h (right):

https://codereview.chromium.org/1128073003/diff/40001/chrome/browser/password...
chrome/browser/password_manager/save_password_infobar_delegate.h:95: // If title
contains Google Smart Lock, then it should be link to help center
On 2015/05/13 18:33:25, dfalcantara wrote:
> nit: add blank line above
> 
> Maybe:
> If set, describes the location of the link to the help center article for
Smart
> Lock.
> 
> ?

Definitely better. Thanks for suggested improvement.

[melandory, 2015-05-13 22:30:15]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-05-13 22:30:15]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1128073003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-05-13 22:31:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128073003/60001

[commit-bot: I haz the power, 2015-05-13 22:38:51]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-05-13 22:39:54]

Patchset 3 (id:??) landed as
https://crrev.com/e12f37ab81281d683bfb36b37e089e80fefc9a01
Cr-Commit-Position: refs/heads/master@{#329737}