Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

Issue 1128073003: [Smart Lock] Make link from brading string (Google Smart Lock) in save password infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/save_password_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
index e3b147239aeb4c4398f35b395a517f399d401689..41d128333bdd9692db4ab79570940cac97b56c71 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
@@ -4,6 +4,11 @@
package org.chromium.chrome.browser.infobar;
+import android.text.SpannableString;
+import android.text.Spanned;
+import android.text.style.ClickableSpan;
+import android.view.View;
+
import org.chromium.base.CalledByNative;
import org.chromium.chrome.browser.ResourceId;
@@ -14,19 +19,28 @@ import org.chromium.chrome.browser.ResourceId;
*/
public class SavePasswordInfoBar extends ConfirmInfoBar {
private final boolean mIsMoreButtonNeeded;
+ private final int mTitleLinkRangeStart;
+ private final int mTitleLinkRangeEnd;
+ private final String mTitle;
@CalledByNative
private static InfoBar show(long nativeInfoBar, int enumeratedIconId, String message,
- String primaryButtonText, String secondaryButtonText, boolean isMoreButtonNeeded) {
+ int titleLinkStart, int titleLinkEnd, String primaryButtonText,
+ String secondaryButtonText, boolean isMoreButtonNeeded) {
return new SavePasswordInfoBar(nativeInfoBar, ResourceId.mapToDrawableId(enumeratedIconId),
- message, primaryButtonText, secondaryButtonText, isMoreButtonNeeded);
+ message, titleLinkStart, titleLinkEnd, primaryButtonText, secondaryButtonText,
+ isMoreButtonNeeded);
}
private SavePasswordInfoBar(long nativeInfoBar, int iconDrawbleId, String message,
- String primaryButtonText, String secondaryButtonText, boolean isMoreButtonNeeded) {
+ int titleLinkStart, int titleLinkEnd, String primaryButtonText,
+ String secondaryButtonText, boolean isMoreButtonNeeded) {
super(nativeInfoBar, null, iconDrawbleId, null, message, null, primaryButtonText,
secondaryButtonText);
mIsMoreButtonNeeded = isMoreButtonNeeded;
+ mTitleLinkRangeStart = titleLinkStart;
+ mTitleLinkRangeEnd = titleLinkEnd;
+ mTitle = message;
}
@Override
@@ -35,5 +49,15 @@ public class SavePasswordInfoBar extends ConfirmInfoBar {
if (mIsMoreButtonNeeded) {
layout.setCustomViewInButtonRow(OverflowSelector.createOverflowSelector(getContext()));
}
+ if (mTitleLinkRangeStart != 0 && mTitleLinkRangeEnd != 0) {
+ SpannableString title = new SpannableString(mTitle);
+ title.setSpan(new ClickableSpan() {
+ @Override
+ public void onClick(View view) {
+ onLinkClicked();
+ }
+ }, mTitleLinkRangeStart, mTitleLinkRangeEnd, Spanned.SPAN_INCLUSIVE_INCLUSIVE);
+ layout.setMessage(title);
+ }
}
}
« no previous file with comments | « no previous file | chrome/browser/password_manager/save_password_infobar_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698