net/http/http_auth_handler_ntlm.cc - Issue 1128043007: Support Kerberos on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_ntlm.cc

Issue 1128043007: Support Kerberos on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mistake in previous Windows fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_ntlm.cc

diff --git a/net/http/http_auth_handler_ntlm.cc b/net/http/http_auth_handler_ntlm.cc

index de0fe290a3c53aad3e083373a2548cdaf98c1193..ecadf4c2915226a7d58eea17207206e030afe25c 100644

--- a/net/http/http_auth_handler_ntlm.cc

+++ b/net/http/http_auth_handler_ntlm.cc

@@ -33,10 +33,8 @@ int HttpAuthHandlerNTLM::GenerateAuthTokenImpl(

const AuthCredentials* credentials, const HttpRequestInfo* request,

const CompletionCallback& callback, std::string* auth_token) {

#if defined(NTLM_SSPI)

- return auth_sspi_.GenerateAuthToken(

- credentials,

- CreateSPN(origin_),

- auth_token);

+ return auth_sspi_.GenerateAuthToken(credentials, CreateSPN(origin_),

+ auth_token, callback);

#else // !defined(NTLM_SSPI)

// TODO(cbentzel): Shouldn't be hitting this case.

if (!credentials) {