net/http/http_auth_gssapi_posix.cc - Issue 1128043007: Support Kerberos on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_gssapi_posix.cc

Issue 1128043007: Support Kerberos on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mistake in previous Windows fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_gssapi_posix.cc

diff --git a/net/http/http_auth_gssapi_posix.cc b/net/http/http_auth_gssapi_posix.cc

index 0e8af79afa7df2010447ecfc8cbf1ee49f39e30d..731180e7d4eddc3cce563dd113cca59593ae36d1 100644

--- a/net/http/http_auth_gssapi_posix.cc

+++ b/net/http/http_auth_gssapi_posix.cc

@@ -719,7 +719,8 @@ HttpAuth::AuthorizationResult HttpAuthGSSAPI::ParseChallenge(

int HttpAuthGSSAPI::GenerateAuthToken(const AuthCredentials* credentials,

const std::string& spn,

- std::string* auth_token) {

+ std::string* auth_token,

+ const CompletionCallback& callback) {

Bernhard Bauer 2015/05/15 15:06:16 Comment out the parameter name like on Windows?

aberent 2015/05/18 13:45:28 Done

DCHECK(auth_token);

gss_buffer_desc input_token = GSS_C_EMPTY_BUFFER;