Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_auth_handler_factory.h

Issue 1128043007: Support Kerberos on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android GN build Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_auth_gssapi_posix.cc ('K') | « net/http/http_auth_gssapi_posix_unittest.cc ('k') | net/http/http_auth_handler_factory.cc » ('j') | net/http/http_auth_handler_negotiate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_factory.h
diff --git a/net/http/http_auth_handler_factory.h b/net/http/http_auth_handler_factory.h
index 06f7f34db55901118f053a082a4d2a2cb3a6862a..eab0d948749646fad72b0b6c8dfd38307fbb0b2a 100644
--- a/net/http/http_auth_handler_factory.h
+++ b/net/http/http_auth_handler_factory.h
@@ -169,7 +169,11 @@ class NET_EXPORT HttpAuthHandlerRegistryFactory
// |host_resolver| must not be NULL.
//
// |gssapi_library_name| specifies the name of the GSSAPI library that will
- // be loaded on all platforms except Windows.
+ // be loaded on Posix platforms other than Android, or of the SSPI library
+ // that will be loaded on Windows.
cbentzel 2015/06/30 12:53:55 The SSPI portion of this comment is incorrect. Cou
aberent 2015/07/02 21:13:36 Done.
+ //
+ // |auth_android_negotiate_account_type| is an Android account type, used to
+ // find the appropriate authenticator service on Android.
cbentzel 2015/06/30 12:53:55 Comment that this is ignored on non-Android platfo
aberent 2015/07/02 21:13:36 Done.
//
// |negotiate_disable_cname_lookup| and |negotiate_enable_port| both control
// how Negotiate does SPN generation, by default these should be false.
@@ -178,6 +182,7 @@ class NET_EXPORT HttpAuthHandlerRegistryFactory
URLSecurityManager* security_manager,
HostResolver* host_resolver,
const std::string& gssapi_library_name,
+ const std::string& auth_android_negotiate_account_type,
bool negotiate_disable_cname_lookup,
bool negotiate_enable_port);
« net/http/http_auth_gssapi_posix.cc ('K') | « net/http/http_auth_gssapi_posix_unittest.cc ('k') | net/http/http_auth_handler_factory.cc » ('j') | net/http/http_auth_handler_negotiate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698