Support Kerberos on Android

net/android/http_auth_negotiate_android_unittest.cc

Index: net/android/http_auth_negotiate_android_unittest.cc
diff --git a/net/android/http_auth_negotiate_android_unittest.cc b/net/android/http_auth_negotiate_android_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6c59cc3d2afaf3eb425d940da1971bdbe058c621
--- /dev/null
+++ b/net/android/http_auth_negotiate_android_unittest.cc
@@ -0,0 +1,93 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/run_loop.h"
+#include "net/android/dummy_spnego_authenticator.h"
+#include "net/android/http_auth_negotiate_android.h"
+#include "net/base/net_errors.h"
+#include "net/base/test_completion_callback.h"
+#include "net/http/http_auth_challenge_tokenizer.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+namespace android {
+
+TEST(HttpAuthNegotiateAndroidTest, GenerateAuthToken) {
+  DummySpnegoAuthenticator::EnsureTestAccountExists();
+
+  std::string auth_token;
+
+  DummySpnegoAuthenticator::SetNextResult(0, "DummyToken");
+
+  HttpAuthNegotiateAndroid auth("org.chromium.test.DummySpnegoAuthenticator");
+  EXPECT_TRUE(auth.Init());
+
+  TestCompletionCallback callback;
+  EXPECT_EQ(ERR_IO_PENDING,
+            auth.GenerateAuthToken(nullptr, "Dummy", &auth_token,
+                                   callback.callback()));
+
+  EXPECT_EQ(OK, callback.WaitForResult());

[Ryan Sleevi, 2015/06/29 13:56:45]

HANG BUG: Is auth.GenerateAuthToken returns a value != ERR_IO_PENDING, this will
hang the test.

Options: You could change line 27 to ASSERT_EQ(), which will abandon execution
if it fails synchronously.

However, you need to determine whether or not it's a *hard* API requirement that
it return asynchronously. I don't think it should be. In that case, you can do

EXPECT_EQ(ok, callback.GetResult(auth.GenerateAuthToken(...,
callback.callback())));

which will allow synchronous or asynchronous completion and avoid any loop
spinning on error conditions

[aberent, 2015/07/02 21:13:35]

Done.

+  EXPECT_EQ("Negotiate DummyToken", auth_token);
+
+  DummySpnegoAuthenticator::RemoveTestAccounts();
+}
+
+TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_FirstRound) {
+  // The first round should just consist of an unadorned "Negotiate" header.
+  HttpAuthNegotiateAndroid auth("org.chromium.test.DummySpnegoAuthenticator");
+  std::string challenge_text = "Negotiate";
+  HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
+                                       challenge_text.end());
+  EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
+            auth.ParseChallenge(&challenge));
+}
+
+TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_UnexpectedTokenFirstRound) {
+  // If the first round challenge has an additional authentication token, it
+  // should be treated as an invalid challenge from the server.
+  HttpAuthNegotiateAndroid auth("org.chromium.test.DummySpnegoAuthenticator");
+  std::string challenge_text = "Negotiate Zm9vYmFy";
+  HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
+                                       challenge_text.end());
+  EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
+            auth.ParseChallenge(&challenge));
+}
+
+TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_TwoRounds) {
+  // The first round should just have "Negotiate", and the second round should
+  // have a valid base64 token associated with it.
+  HttpAuthNegotiateAndroid auth("org.chromium.test.DummySpnegoAuthenticator");
+  std::string first_challenge_text = "Negotiate";
+  HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
+                                             first_challenge_text.end());
+  EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
+            auth.ParseChallenge(&first_challenge));
+
+  std::string second_challenge_text = "Negotiate Zm9vYmFy";
+  HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
+                                              second_challenge_text.end());
+  EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
+            auth.ParseChallenge(&second_challenge));
+}
+
+TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_MissingTokenSecondRound) {
+  // If a later-round challenge is simply "Negotiate", it should be treated as
+  // an authentication challenge rejection from the server or proxy.
+  HttpAuthNegotiateAndroid auth("org.chromium.test.DummySpnegoAuthenticator");
+  std::string first_challenge_text = "Negotiate";
+  HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
+                                             first_challenge_text.end());
+  EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
+            auth.ParseChallenge(&first_challenge));
+
+  std::string second_challenge_text = "Negotiate";
+  HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
+                                              second_challenge_text.end());
+  EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_REJECT,
+            auth.ParseChallenge(&second_challenge));
+}
+
+}  // namespace android
+}  // namespace net