build/android/pylib/gtest/test_package_exe.py - Issue 1128043007: Support Kerberos on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_exe.py

Issue 1128043007: Support Kerberos on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Deal with comments and build and test failures. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/test_package_exe.py

diff --git a/build/android/pylib/gtest/test_package_exe.py b/build/android/pylib/gtest/test_package_exe.py

index 87071b5bd4c186352b1971445f6573cdbcc78a76..5574453e3f9b5639951a5f3589a26d5f9e028f87 100644

--- a/build/android/pylib/gtest/test_package_exe.py

+++ b/build/android/pylib/gtest/test_package_exe.py

@@ -127,7 +127,10 @@ class TestPackageExecutable(TestPackage):

return gtest_test_instance.ParseGTestListTests(output)

#override

- def SpawnTestProcess(self, device):

+ def SpawnTestProcess(self, device, tests_run_in_subthread=False):

+ if tests_run_in_subthread:

+ raise NotImplementedError(

+ 'tests_run_in_subthread not supported for executables')

args = ['adb', '-s', str(device), 'shell', 'sh',

constants.TEST_EXECUTABLE_DIR + '/chrome_test_runner.sh']

logging.info(args)