Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_auth_handler_factory_unittest.cc

Issue 1128043007: Support Kerberos on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a nit I had missed. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_auth_gssapi_posix.h ('K') | « net/http/http_auth_handler_factory.cc ('k') | net/http/http_auth_handler_negotiate.h » ('j') | net/http/http_auth_handler_negotiate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_factory_unittest.cc
diff --git a/net/http/http_auth_handler_factory_unittest.cc b/net/http/http_auth_handler_factory_unittest.cc
index 2aa7958800c18eaf32cdf3e7f2060909577445aa..241731ef8e45617080c353db2abc6550e5ce8584 100644
--- a/net/http/http_auth_handler_factory_unittest.cc
+++ b/net/http/http_auth_handler_factory_unittest.cc
@@ -172,7 +172,8 @@ TEST(HttpAuthHandlerFactoryTest, DefaultFactory) {
server_origin,
BoundNetLog(),
&handler);
-#if defined(USE_KERBEROS)
+// Note the default factory doesn't support KERBOROS on Android
Bernhard Bauer 2015/06/10 17:11:03 Nit: KERBEROS
aberent 2015/06/15 15:52:20 Done.
+#if defined(USE_KERBEROS) && !defined(OS_ANDROID)
EXPECT_EQ(OK, rv);
ASSERT_FALSE(handler.get() == NULL);
EXPECT_EQ(HttpAuth::AUTH_SCHEME_NEGOTIATE, handler->auth_scheme());
@@ -183,7 +184,7 @@ TEST(HttpAuthHandlerFactoryTest, DefaultFactory) {
#else
EXPECT_EQ(ERR_UNSUPPORTED_AUTH_SCHEME, rv);
EXPECT_TRUE(handler.get() == NULL);
-#endif // defined(USE_KERBEROS)
+#endif // defined(USE_KERBEROS) && !defined(OS_ANDROID)
}
}
« net/http/http_auth_gssapi_posix.h ('K') | « net/http/http_auth_handler_factory.cc ('k') | net/http/http_auth_handler_negotiate.h » ('j') | net/http/http_auth_handler_negotiate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698