net/http/http_auth_sspi_win.cc - Issue 1128043007: Support Kerberos on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_sspi_win.cc

Issue 1128043007: Support Kerberos on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes for bauerb@'s comments, plus some other minor fixes. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_sspi_win.cc

diff --git a/net/http/http_auth_sspi_win.cc b/net/http/http_auth_sspi_win.cc

index 56b1c8c026315d5b51e34c18ac2e9af0a5ddbd48..52593980cb70de89df7819c7ba17635581829ce9 100644

--- a/net/http/http_auth_sspi_win.cc

+++ b/net/http/http_auth_sspi_win.cc

@@ -312,7 +312,8 @@ HttpAuth::AuthorizationResult HttpAuthSSPI::ParseChallenge(

int HttpAuthSSPI::GenerateAuthToken(const AuthCredentials* credentials,

const std::string& spn,

- std::string* auth_token) {

+ std::string* auth_token,

+ const CompletionCallback& /*callback*/) {

// Initial challenge.

if (!SecIsValidHandle(&cred_)) {

int rv = OnFirstRound(credentials);