net/http/http_auth_handler_basic_unittest.cc - Issue 1128043007: Support Kerberos on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_basic_unittest.cc

Issue 1128043007: Support Kerberos on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_basic_unittest.cc

diff --git a/net/http/http_auth_handler_basic_unittest.cc b/net/http/http_auth_handler_basic_unittest.cc

index 60e588291ca1fab44a2b9278e74932c2feff1c73..37c1adf25ace60d486b480cf2c20151d24126854 100644

--- a/net/http/http_auth_handler_basic_unittest.cc

+++ b/net/http/http_auth_handler_basic_unittest.cc

@@ -44,7 +44,7 @@ TEST(HttpAuthHandlerBasicTest, GenerateAuthToken) {

std::string auth_token;

TestCompletionCallback callback;

int rv = basic->GenerateAuthToken(&credentials, &request_info,

- callback.callback(), &auth_token);

+ callback.callback(), &auth_token, NULL);

Bernhard Bauer 2015/05/15 15:06:16 Use nullptr instead of NULL.

aberent 2015/05/18 13:45:27 Shouldn't have been here at all! Fixed in a later

EXPECT_EQ(OK, rv);

EXPECT_STREQ(tests[i].expected_credentials, auth_token.c_str());

}