Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 11280283: Extract the code of showing a dragging window on another display from PhantomWindowController. (Closed)

Created:
8 years ago by mazda
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Extract the code of showing a dragging window on another display from PhantomWindowController. PhantomWindowController shows two styles of window, STYLE_SHADOW and STYLE_DRAGGING. Although STYLE_SHADOW is specific to workspace, STYLE_DRAGGING is not specific to workspace. This CL separates this feature into two classes so that the STYLE_DRAGGING part can be used from non-workspace specific code - Extract the STYLE_DRAGGING part from PhantomWindowController into DragWindowController. - Move the ownership of the copied window layer from WorkspaceWindowResizer to DragWindowController. BUG=156519 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171048

Patch Set 1 #

Total comments: 2

Patch Set 2 : assign NULL after deleting Layer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -190 lines) Patch
M ash/ash.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/shell_window_ids.h View 1 chunk +1 line, -1 line 0 comments Download
A ash/wm/drag_window_controller.h View 1 chunk +97 lines, -0 lines 0 comments Download
A ash/wm/drag_window_controller.cc View 1 1 chunk +125 lines, -0 lines 0 comments Download
M ash/wm/gestures/system_pinch_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.h View 6 chunks +2 lines, -37 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 7 chunks +11 lines, -74 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 6 chunks +4 lines, -10 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 10 chunks +16 lines, -42 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 7 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mazda
Could you review this change? This is a part of refactorings necessary to enable modal ...
8 years ago (2012-12-04 01:50:23 UTC) #1
sky
Nice cleanup, LGTM https://codereview.chromium.org/11280283/diff/1/ash/wm/drag_window_controller.cc File ash/wm/drag_window_controller.cc (right): https://codereview.chromium.org/11280283/diff/1/ash/wm/drag_window_controller.cc#newcode53 ash/wm/drag_window_controller.cc:53: views::corewm::DeepDeleteLayers(layer_); NULL out layer_ after you ...
8 years ago (2012-12-04 15:50:37 UTC) #2
mazda
https://codereview.chromium.org/11280283/diff/1/ash/wm/drag_window_controller.cc File ash/wm/drag_window_controller.cc (right): https://codereview.chromium.org/11280283/diff/1/ash/wm/drag_window_controller.cc#newcode53 ash/wm/drag_window_controller.cc:53: views::corewm::DeepDeleteLayers(layer_); On 2012/12/04 15:50:37, sky wrote: > NULL out ...
8 years ago (2012-12-04 17:22:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/11280283/11001
8 years ago (2012-12-04 18:29:09 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-04 21:18:23 UTC) #5
Message was sent while issue was closed.
Change committed as 171048

Powered by Google App Engine
This is Rietveld 408576698