Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: mandoline/app/BUILD.gn

Issue 1128023007: Fix missing mandoline deps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mandoline/app/desktop/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/app/BUILD.gn
diff --git a/mandoline/app/BUILD.gn b/mandoline/app/BUILD.gn
index bbf483dd41b5e7a1d013cf71872406c46816633a..e74aeb1f76f13a9ca5edf0281c85afed75a2c67d 100644
--- a/mandoline/app/BUILD.gn
+++ b/mandoline/app/BUILD.gn
@@ -16,7 +16,6 @@ group("app") {
}
data_deps = [
- "//components/html_viewer",
msw 2015/05/15 16:53:10 Why does moving this to mandoline/app/desktop help
jam 2015/05/18 14:21:51 the issue is that one when builds "mandoline", tha
msw 2015/05/18 18:04:42 Ah ok, then shouldn't we move these other data dep
jam 2015/05/20 15:45:28 I don't know why exactly this app group was added.
"//mandoline/ui/browser",
"//mandoline/services/core_services",
"//mojo/runner:mojo_runner",
« no previous file with comments | « no previous file | mandoline/app/desktop/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698