Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: mandoline/app/BUILD.gn

Issue 1128023007: Fix missing mandoline deps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mandoline/app/desktop/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/mojo/src/mojo/public/mojo.gni") 5 import("//third_party/mojo/src/mojo/public/mojo.gni")
6 6
7 group("app") { 7 group("app") {
8 deps = [ 8 deps = [
9 "//mandoline/ui", 9 "//mandoline/ui",
10 ] 10 ]
11 11
12 if (is_android) { 12 if (is_android) {
13 deps += [ "//mandoline/app/android" ] 13 deps += [ "//mandoline/app/android" ]
14 } else { 14 } else {
15 deps += [ "//mandoline/app/desktop" ] 15 deps += [ "//mandoline/app/desktop" ]
16 } 16 }
17 17
18 data_deps = [ 18 data_deps = [
19 "//components/html_viewer",
msw 2015/05/15 16:53:10 Why does moving this to mandoline/app/desktop help
jam 2015/05/18 14:21:51 the issue is that one when builds "mandoline", tha
msw 2015/05/18 18:04:42 Ah ok, then shouldn't we move these other data dep
jam 2015/05/20 15:45:28 I don't know why exactly this app group was added.
20 "//mandoline/ui/browser", 19 "//mandoline/ui/browser",
21 "//mandoline/services/core_services", 20 "//mandoline/services/core_services",
22 "//mojo/runner:mojo_runner", 21 "//mojo/runner:mojo_runner",
23 ] 22 ]
24 } 23 }
OLDNEW
« no previous file with comments | « no previous file | mandoline/app/desktop/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698