DescriptionThis patch changes navigateTo() function to simplify code:
- Remove addOneShortEventListener + navigateTo pattern.
- Remove if (list.parentId == newParentId) pattern.
- Replace boolean parameter opt_updateHashNow to callback function to avoid using boolean argument.
This patch also fixes bug 163582 to set focus to folder name input box at right time.
This re-factoring reduces 30 lines of total code size.
* navigateTo(): Change to take callback to call at BookmarkList.load event.
* updateParentId(): Add comments and replace if-statement by conditional operator.
* showInFolder(): Change to check whether list.selectedItem is null or not, before using it. Rename callback function for navigateTo() from f() to selectItem().
* newFolder(): Change to set edit mode for new folder after navigateTo().
Related review:
https://codereview.chromium.org/11411162
BUG=163582
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171119
Patch Set 1 : 2012-11-28T17:45 #
Messages
Total messages: 3 (0 generated)
|