Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 11411162: Adding new folder/page in selected folder on context menu/organize button (Closed)

Created:
8 years ago by yosin_UTC9
Modified:
8 years ago
CC:
chromium-reviews, kenjibaheux, yoichio
Visibility:
Public.

Description

This patch changes behavior of "Add Folder"/"Add Page" menu item of context menu and "Organize" menu. This patch changes "Add Folder"/"Add Page" to use parent folder id from folder id which list view displaying or selected folder in list view, which context menu displayed. Before this patch, "Add Folder"/"Add Page" created new item in current folder of list view. BUG=123689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169581

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -34 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 2 chunks +70 lines, -34 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
yosin_UTC9
Hi Eric, Could you review this patch? Thanks in advance.
8 years ago (2012-11-26 06:31:07 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/11411162/diff/1/chrome/browser/resources/bookmark_manager/js/main.js File chrome/browser/resources/bookmark_manager/js/main.js (right): https://codereview.chromium.org/11411162/diff/1/chrome/browser/resources/bookmark_manager/js/main.js#newcode1588 chrome/browser/resources/bookmark_manager/js/main.js:1588: navigateTo(parentId, true); Maybe we should have navigateTo take ...
8 years ago (2012-11-26 14:50:44 UTC) #2
yosin_UTC9
8 years ago (2012-11-27 05:04:15 UTC) #3
Message was sent while issue was closed.
> Maybe we should have navigateTo take an optional callback?
Sounds good. I'll do another patch. Stay tune. ;-)

Powered by Google App Engine
This is Rietveld 408576698