chrome/installer/util/google_chrome_distribution.cc - Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/browser_distribution.h ('K') | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_chrome_sxs_distribution.h » ('j') | chrome/installer/util/google_chrome_sxs_distribution.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index d9c4e6769ba508be99e9321abd148451bc6ba629..1e12818c1c30b8209d7acb591fb3865e84c7ce44 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -877,4 +877,7 @@ void GoogleChromeDistribution::InactiveUserToastExperiment(int flavor,

base::LaunchProcess(cmd, base::LaunchOptions(), NULL);

}

+bool GoogleChromeDistribution::ShouldWriteExperimentLabels() const {

grt (UTC plus 2) 2012/11/24 02:58:37 I think this should be moved down below the #endif

SteveT 2012/11/26 20:45:06 Done.

+ return true;

#endif