chrome/installer/util/google_chrome_distribution.cc - Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/installer/util/browser_distribution.h ('K') | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_chrome_sxs_distribution.h » ('j') | chrome/installer/util/google_chrome_sxs_distribution.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // This file defines specific implementation of BrowserDistribution class for	5 // This file defines specific implementation of BrowserDistribution class for

6 // Google Chrome.	6 // Google Chrome.

7	7

8 #include "chrome/installer/util/google_chrome_distribution.h"	8 #include "chrome/installer/util/google_chrome_distribution.h"

9	9

10 #include <vector>	10 #include <vector>

(...skipping 859 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
870 // we waited for chrome to exit so the uninstall would not detect chrome	870 // we waited for chrome to exit so the uninstall would not detect chrome

871 // running.	871 // running.

872 bool system_level_toast = CommandLine::ForCurrentProcess()->HasSwitch(	872 bool system_level_toast = CommandLine::ForCurrentProcess()->HasSwitch(

873 installer::switches::kSystemLevelToast);	873 installer::switches::kSystemLevelToast);

874	874

875 CommandLine cmd(InstallUtil::GetChromeUninstallCmd(system_level_toast,	875 CommandLine cmd(InstallUtil::GetChromeUninstallCmd(system_level_toast,

876 GetType()));	876 GetType()));

877 base::LaunchProcess(cmd, base::LaunchOptions(), NULL);	877 base::LaunchProcess(cmd, base::LaunchOptions(), NULL);

878 }	878 }

879	879

	880 bool GoogleChromeDistribution::ShouldWriteExperimentLabels() const {
	grt (UTC plus 2) 2012/11/24 02:58:37 I think this should be moved down below the #endif I think this should be moved down below the #endif. You'll need an implementation in the _dummy.cc, too. SteveT 2012/11/26 20:45:06 Done. Show quoted text On 2012/11/24 02:58:37, grt wrote: > I think this should be moved down below the #endif. You'll need an > implementation in the _dummy.cc, too. Done.
	881 return true;

	882 }

880 #endif	883 #endif

OLD	NEW