Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1127963005: Fix deprecation declarations in headers (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
ulan, vogelheim
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix deprecation declarations in headers BUG=none R=ulan@chromium.org LOG=n Committed: https://crrev.com/7590d302e37dd04664ef2bd68042063a8e634599 Cr-Commit-Position: refs/heads/master@{#28407}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M include/v8.h View 8 chunks +32 lines, -30 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-15 00:40:50 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 7 months ago (2015-05-15 00:51:04 UTC) #3
vogelheim
lgtm https://codereview.chromium.org/1127963005/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1127963005/diff/1/include/v8.h#newcode7298 include/v8.h:7298: .ToLocalChecked(), Is this meant to be in this ...
5 years, 7 months ago (2015-05-15 01:01:22 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1127963005/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1127963005/diff/1/include/v8.h#newcode7298 include/v8.h:7298: .ToLocalChecked(), On 2015/05/15 01:01:22, vogelheim wrote: > Is this ...
5 years, 7 months ago (2015-05-15 01:13:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127963005/1
5 years, 7 months ago (2015-05-15 01:13:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 01:48:31 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 01:48:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7590d302e37dd04664ef2bd68042063a8e634599
Cr-Commit-Position: refs/heads/master@{#28407}

Powered by Google App Engine
This is Rietveld 408576698