Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: include/v8.h

Issue 1127963005: Fix deprecation declarations in headers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 5ce6dd5064fa30763ebd031fc30de117495d9814..d4b664a5495a2481f3db61274be6ef6948889371 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1390,7 +1390,7 @@ class V8_EXPORT Message {
public:
Local<String> Get() const;
- V8_DEPRECATE_SOON("Use maybe version", Local<String> GetSourceLine()) const;
+ V8_DEPRECATE_SOON("Use maybe version", Local<String> GetSourceLine() const);
V8_WARN_UNUSED_RESULT MaybeLocal<String> GetSourceLine(
Local<Context> context) const;
@@ -1416,7 +1416,7 @@ class V8_EXPORT Message {
/**
* Returns the number, 1-based, of the line where the error occurred.
*/
- V8_DEPRECATE_SOON("Use maybe version", int GetLineNumber()) const;
+ V8_DEPRECATE_SOON("Use maybe version", int GetLineNumber() const);
V8_WARN_UNUSED_RESULT Maybe<int> GetLineNumber(Local<Context> context) const;
/**
@@ -1435,14 +1435,14 @@ class V8_EXPORT Message {
* Returns the index within the line of the first character where
* the error occurred.
*/
- V8_DEPRECATE_SOON("Use maybe version", int GetStartColumn()) const;
+ V8_DEPRECATE_SOON("Use maybe version", int GetStartColumn() const);
V8_WARN_UNUSED_RESULT Maybe<int> GetStartColumn(Local<Context> context) const;
/**
* Returns the index within the line of the last character where
* the error occurred.
*/
- V8_DEPRECATE_SOON("Use maybe version", int GetEndColumn()) const;
+ V8_DEPRECATE_SOON("Use maybe version", int GetEndColumn() const);
V8_WARN_UNUSED_RESULT Maybe<int> GetEndColumn(Local<Context> context) const;
/**
@@ -1910,39 +1910,39 @@ class V8_EXPORT Value : public Data {
V8_WARN_UNUSED_RESULT MaybeLocal<Int32> ToInt32(Local<Context> context) const;
V8_DEPRECATE_SOON("Use maybe version",
- Local<Boolean> ToBoolean(Isolate* isolate)) const;
+ Local<Boolean> ToBoolean(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version",
- Local<Number> ToNumber(Isolate* isolate)) const;
+ Local<Number> ToNumber(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version",
- Local<String> ToString(Isolate* isolate)) const;
+ Local<String> ToString(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version",
- Local<String> ToDetailString(Isolate* isolate)) const;
+ Local<String> ToDetailString(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version",
- Local<Object> ToObject(Isolate* isolate)) const;
+ Local<Object> ToObject(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version",
- Local<Integer> ToInteger(Isolate* isolate)) const;
+ Local<Integer> ToInteger(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version",
- Local<Uint32> ToUint32(Isolate* isolate)) const;
+ Local<Uint32> ToUint32(Isolate* isolate) const);
V8_DEPRECATE_SOON("Use maybe version",
- Local<Int32> ToInt32(Isolate* isolate)) const;
+ Local<Int32> ToInt32(Isolate* isolate) const);
inline V8_DEPRECATE_SOON("Use maybe version",
- Local<Boolean> ToBoolean()) const;
- inline V8_DEPRECATE_SOON("Use maybe version", Local<Number> ToNumber()) const;
- inline V8_DEPRECATE_SOON("Use maybe version", Local<String> ToString()) const;
+ Local<Boolean> ToBoolean() const);
+ inline V8_DEPRECATE_SOON("Use maybe version", Local<Number> ToNumber() const);
+ inline V8_DEPRECATE_SOON("Use maybe version", Local<String> ToString() const);
inline V8_DEPRECATE_SOON("Use maybe version",
- Local<String> ToDetailString()) const;
- inline V8_DEPRECATE_SOON("Use maybe version", Local<Object> ToObject()) const;
+ Local<String> ToDetailString() const);
+ inline V8_DEPRECATE_SOON("Use maybe version", Local<Object> ToObject() const);
inline V8_DEPRECATE_SOON("Use maybe version",
- Local<Integer> ToInteger()) const;
- inline V8_DEPRECATE_SOON("Use maybe version", Local<Uint32> ToUint32()) const;
- inline V8_DEPRECATE_SOON("Use maybe version", Local<Int32> ToInt32()) const;
+ Local<Integer> ToInteger() const);
+ inline V8_DEPRECATE_SOON("Use maybe version", Local<Uint32> ToUint32() const);
+ inline V8_DEPRECATE_SOON("Use maybe version", Local<Int32> ToInt32() const);
/**
* Attempts to convert a string to an array index.
* Returns an empty handle if the conversion fails.
*/
- V8_DEPRECATE_SOON("Use maybe version", Local<Uint32> ToArrayIndex()) const;
+ V8_DEPRECATE_SOON("Use maybe version", Local<Uint32> ToArrayIndex() const);
V8_WARN_UNUSED_RESULT MaybeLocal<Uint32> ToArrayIndex(
Local<Context> context) const;
@@ -1954,14 +1954,14 @@ class V8_EXPORT Value : public Data {
Local<Context> context) const;
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
- V8_DEPRECATE_SOON("Use maybe version", bool BooleanValue()) const;
- V8_DEPRECATE_SOON("Use maybe version", double NumberValue()) const;
- V8_DEPRECATE_SOON("Use maybe version", int64_t IntegerValue()) const;
- V8_DEPRECATE_SOON("Use maybe version", uint32_t Uint32Value()) const;
- V8_DEPRECATE_SOON("Use maybe version", int32_t Int32Value()) const;
+ V8_DEPRECATE_SOON("Use maybe version", bool BooleanValue() const);
+ V8_DEPRECATE_SOON("Use maybe version", double NumberValue() const);
+ V8_DEPRECATE_SOON("Use maybe version", int64_t IntegerValue() const);
+ V8_DEPRECATE_SOON("Use maybe version", uint32_t Uint32Value() const);
+ V8_DEPRECATE_SOON("Use maybe version", int32_t Int32Value() const);
/** JS == */
- V8_DEPRECATE_SOON("Use maybe version", bool Equals(Handle<Value> that)) const;
+ V8_DEPRECATE_SOON("Use maybe version", bool Equals(Handle<Value> that) const);
V8_WARN_UNUSED_RESULT Maybe<bool> Equals(Local<Context> context,
Handle<Value> that) const;
bool StrictEquals(Handle<Value> that) const;
@@ -3077,7 +3077,7 @@ class V8_EXPORT Function : public Object {
V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
Local<Context> context, int argc, Handle<Value> argv[]) const;
- V8_DEPRECATE_SOON("Use maybe version", Local<Object> NewInstance()) const;
+ V8_DEPRECATE_SOON("Use maybe version", Local<Object> NewInstance() const);
V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
Local<Context> context) const {
return NewInstance(context, 0, nullptr);
@@ -6175,7 +6175,7 @@ class V8_EXPORT TryCatch {
* Returns the .stack property of the thrown object. If no .stack
* property is present an empty handle is returned.
*/
- V8_DEPRECATE_SOON("Use maybe version.", Local<Value> StackTrace()) const;
+ V8_DEPRECATE_SOON("Use maybe version.", Local<Value> StackTrace() const);
V8_WARN_UNUSED_RESULT MaybeLocal<Value> StackTrace(
Local<Context> context) const;
@@ -7294,7 +7294,9 @@ Handle<Boolean> Boolean::New(Isolate* isolate, bool value) {
void Template::Set(Isolate* isolate, const char* name, v8::Handle<Data> value) {
- Set(v8::String::NewFromUtf8(isolate, name), value);
+ Set(v8::String::NewFromUtf8(isolate, name, NewStringType::kNormal)
+ .ToLocalChecked(),
vogelheim 2015/05/15 01:01:22 Is this meant to be in this CL? (Looks good, just
jochen (gone - plz use gerrit) 2015/05/15 01:13:06 yes, this was a call to a to-be deprecated API...
+ value);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698