Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1127963003: Revert of cc: Adding DidFinishImplFrame to LTHI. (Closed)

Created:
5 years, 7 months ago by Kunihiko Sakamoto
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Adding DidFinishImplFrame to LTHI. (patchset #10 id:180001 of https://codereview.chromium.org/1111743002/) Reason for revert: Broke Win x64 GN build. http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1013/steps/compile/logs/stdio Original issue's description: > cc: Adding DidFinishImplFrame to LTHI. > > This change moves the responsibility of clearing state inside the LTHI after an > impl frame is finished from the thread proxies to the LTHI class. This makes > WillBeginImplFrame and DidFinishImplFrame a logical pair. > > This CL also; > * Adds a test that checks the number of WillBeginImplFrame > calls matches the DidFinishImplFrame calls. > * Cleans up classes in cc/test/layer_tree_test.h around WillBeginImplFrame. > * Removes the UpdateCurrentBeginFrameArgs / ResetCurrentBeginFrameArgs methods. > * Fixes a bug where STP was calling ResetCurrentBeginFrameArgs twice every frame. > > BUG=346230, 481810 > R=brianderson,enne > > Committed: https://crrev.com/2caee4f89de17858822c11379da9c6cd80f90708 > Cr-Commit-Position: refs/heads/master@{#328689} TBR=brianderson@chromium.org,enne@chromium.org,danakj@chromium.org,sunnyps@chromium.org,mithro@mithis.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346230, 481810 Committed: https://crrev.com/4279b872d0187987853fb1f9283486be50efe26a Cr-Commit-Position: refs/heads/master@{#328692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -122 lines) Patch
M cc/resources/tile_manager_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.h View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 6 chunks +10 lines, -21 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +1 line, -57 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 3 chunks +1 line, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 7 chunks +3 lines, -15 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kunihiko Sakamoto
Created Revert of cc: Adding DidFinishImplFrame to LTHI.
5 years, 7 months ago (2015-05-07 03:30:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127963003/1
5 years, 7 months ago (2015-05-07 03:31:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 03:36:41 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 03:37:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4279b872d0187987853fb1f9283486be50efe26a
Cr-Commit-Position: refs/heads/master@{#328692}

Powered by Google App Engine
This is Rietveld 408576698