Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1127713002: Move RectBatch to GrRectBatch (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@command-builder
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Patch Set 4 : rebase #

Patch Set 5 : tweaks #

Patch Set 6 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -462 lines) Patch
M gyp/gpu.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 3 chunks +1 line, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 2 chunks +0 lines, -240 lines 0 comments Download
A src/gpu/GrRectBatch.h View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A + src/gpu/GrRectBatch.cpp View 1 2 3 3 chunks +14 lines, -204 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
joshualitt
Mostly just a move. I wanted to name it GrRect, but there was a conflict ...
5 years, 7 months ago (2015-05-04 20:21:35 UTC) #2
robertphillips
lgtm
5 years, 7 months ago (2015-05-05 14:58:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127713002/80001
5 years, 7 months ago (2015-05-05 17:19:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/853)
5 years, 7 months ago (2015-05-05 17:20:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127713002/100001
5 years, 7 months ago (2015-05-05 17:32:35 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 17:46:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/ad17cfc8c72515176a1b191767caac48e316b43a

Powered by Google App Engine
This is Rietveld 408576698