Issue 1127603003: ignore_result()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127603003: ignore_result() (Closed)

Created:
5 years, 7 months ago by mtklein_C

Modified:
5 years, 7 months ago

Reviewers:
tfarina, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

ignore_result() BUG=skia:3801 Committed: https://skia.googlesource.com/skia/+/19e259b1ee4e4f42133250cca605ee77c3e40702

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tools/flags/SkCommandLineFlags.cpp	View		2 chunks	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tfarina

lgtm thanks https://codereview.chromium.org/1127603003/diff/1/tools/flags/SkCommandLineFlags.cpp File tools/flags/SkCommandLineFlags.cpp (right): https://codereview.chromium.org/1127603003/diff/1/tools/flags/SkCommandLineFlags.cpp#newcode14 tools/flags/SkCommandLineFlags.cpp:14: template <typename T> static void ignore_result(const T&) ...

5 years, 7 months ago (2015-05-04 17:39:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127603003/1

5 years, 7 months ago (2015-05-04 17:47:35 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-04 17:54:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19e259b1ee4e4f42133250cca605ee77c3e40702

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages